From: Junio C Hamano <gitster@pobox•com>
To: "Matthias Aßhauer" <mha1993@live•de>
Cc: <git@vger•kernel.org>, "'Thomas Gummerer'" <t.gummerer@gmail•com>,
"'Stefan Beller'" <sbeller@google•com>
Subject: Re: AW: [PATCH 1/2] stash--helper: implement "git stash--helper"
Date: Fri, 29 Jan 2016 11:58:48 -0800 [thread overview]
Message-ID: <xmqqlh78ximf.fsf@gitster.mtv.corp.google.com> (raw)
In-Reply-To: <BLU436-SMTP10996033F3EBFE2E8639F96A5DB0@phx.gbl> ("Matthias Aßhauer"'s message of "Fri, 29 Jan 2016 20:32:45 +0100")
Matthias Aßhauer <mha1993@live•de> writes:
[administrivia: please wrap your lines to reasonable lengths]
>> Honestly, I had high hopes after seeing the "we are rewriting it
>> in C" but I am not enthused after seeing this. I was hoping that
>> the rewritten version would do this all in-core, by calling these
>> functions that we already have:
>
> These functions might be obvious to you, but I'm new to git's
> source code, ...
Ahh, I didn't realize I was talking with somebody unfamiliar with
the codebase. Apologies.
Nevertheless, the list of functions I gave are a good starting
point; they are widely used building blocks in the codebase.
> I'll be working on a v2 that incorporates the feedback from you,
> Thomas Gummerer and Stefan Beller then. Further feedback is of
> course welcome.
Thanks.
next prev parent reply other threads:[~2016-01-29 19:58 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-28 19:38 [PATCH 0/2] Make stash a builtin Matthias Aßhauer
2016-01-28 20:36 ` [PATCH 1/2] stash--helper: implement "git stash--helper" Matthias Asshauer
2016-01-28 20:36 ` [PATCH 2/2] stash: use "stash--helper" Matthias Asshauer
2016-01-28 20:59 ` Stefan Beller
2016-01-28 21:25 ` AW: " Matthias Aßhauer
2016-01-28 21:41 ` Stefan Beller
2016-01-28 23:28 ` Roberto Tyley
2016-01-29 19:37 ` AW: " Matthias Aßhauer
2016-01-29 11:21 ` Thomas Gummerer
2016-01-29 18:34 ` Junio C Hamano
2016-01-28 23:06 ` [PATCH 1/2] stash--helper: implement "git stash--helper" Junio C Hamano
2016-01-29 19:32 ` AW: " Matthias Aßhauer
2016-01-29 19:58 ` Junio C Hamano [this message]
2016-02-01 23:36 ` Michael Blume
2016-02-01 23:40 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqlh78ximf.fsf@gitster.mtv.corp.google.com \
--to=gitster@pobox$(echo .)com \
--cc=git@vger$(echo .)kernel.org \
--cc=mha1993@live$(echo .)de \
--cc=sbeller@google$(echo .)com \
--cc=t.gummerer@gmail$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox