From: Junio C Hamano <gitster@pobox•com>
To: "Torsten Bögershausen" <tboegi@web•de>
Cc: Elia Pinto <gitter.spiros@gmail•com>,
git@vger•kernel.org, remi.galan-alfonso@ensimag•grenoble-inp.fr
Subject: Re: [PATCH v3] http: add support for specifying the SSL version
Date: Fri, 14 Aug 2015 10:21:37 -0700 [thread overview]
Message-ID: <xmqqlhddiy5a.fsf@gitster.dls.corp.google.com> (raw)
In-Reply-To: <55CCBF6F.3070808@web.de> ("Torsten Bögershausen"'s message of "Thu, 13 Aug 2015 18:01:51 +0200")
Torsten Bögershausen <tboegi@web•de> writes:
>> diff --git a/Documentation/config.txt b/Documentation/config.txt
>> index 315f271..b23b01a 100644
>> --- a/Documentation/config.txt
>> +++ b/Documentation/config.txt
>> @@ -1595,6 +1595,28 @@ http.saveCookies::
>> If set, store cookies received during requests to the file specified by
>> http.cookieFile. Has no effect if http.cookieFile is unset.
>>
>> +http.sslVersion::
> should this be https.sslVersion ?
> (http doesn't use ssl)
But there are sslCipherList, etc., already present, and more
importantly, I think you want http.proxy to apply even if you happen
to be talking http over SSL.
More importantly, given that we have the "limited to this URL"
mechanism "http.<url>.<variable>" that overrides "http.<variable>",
introducing "https.sslWhatEver" would force people to have two
configuration sections for no real benefit, other than silencing
pedants that want to say "these things should be defined only for
https".
>> + if (sslversions[i].name != NULL && *sslversions[i].name &&
>> !strcmp(ssl_version,sslversions[i].name)) {
>> + curl_easy_setopt(result, CURLOPT_SSLVERSION,
>> + sslversions[i].ssl_version);
> This is what my man page says:
> CURLcode curl_easy_setopt(CURL *handle, CURLoption option, parameter);
> []
>
> RETURN VALUE
> CURLE_OK (zero) means that the option was set properly...
> Should the return value checked (and we die() if we fail ?
Probably. Do we check status from other calls to setopt?
next prev parent reply other threads:[~2015-08-14 17:21 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-13 15:28 [PATCH v3] http: add support for specifying the SSL version Elia Pinto
2015-08-13 15:47 ` Eric Sunshine
2015-08-13 15:58 ` Elia Pinto
2015-08-13 16:11 ` Eric Sunshine
2015-08-13 16:15 ` Elia Pinto
2015-08-13 16:37 ` Eric Sunshine
2015-08-13 16:49 ` Eric Sunshine
2015-08-13 16:01 ` Torsten Bögershausen
2015-08-13 16:10 ` Elia Pinto
2015-08-13 16:24 ` Ilari Liusvaara
2015-08-13 16:33 ` Elia Pinto
2015-08-14 17:21 ` Junio C Hamano [this message]
2015-08-14 19:51 ` Elia Pinto
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqlhddiy5a.fsf@gitster.dls.corp.google.com \
--to=gitster@pobox$(echo .)com \
--cc=git@vger$(echo .)kernel.org \
--cc=gitter.spiros@gmail$(echo .)com \
--cc=remi.galan-alfonso@ensimag$(echo .)grenoble-inp.fr \
--cc=tboegi@web$(echo .)de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox