From: Junio C Hamano <gitster@pobox•com>
To: Jeff King <peff@peff•net>
Cc: Nicolas Pitre <nico@fluxnic•net>, Duy Nguyen <pclouds@gmail•com>,
Git Mailing List <git@vger•kernel.org>
Subject: Re: Pack v4 again..
Date: Sun, 15 Feb 2015 23:12:24 -0800 [thread overview]
Message-ID: <xmqqlhjy72jr.fsf@gitster.dls.corp.google.com> (raw)
In-Reply-To: <20150216064537.GF32381@peff.net> (Jeff King's message of "Mon, 16 Feb 2015 01:45:38 -0500")
Jeff King <peff@peff•net> writes:
> 2. Calculating reachability for packing[1] spends a lot of time in
> lookup_object, as we have to go through each tree saying "have we
> seen object 1234abcd yet?". If we could instead just view the
> differences, we would not have to make those hash lookups for
> entries whose objects we know we have seen.
Hmm, that is an interesting idea.
> So in short, we may end up anywhere within a tree object and need to
> walk backwards to the start of the entry. But we cannot walk backwards
> looking for a NUL, because it may also be part of a sha1. You can only
> reliably parse a git tree by starting at the beginning of the stream and
> going forwards[3].
That in general is true for non deltified tree object (you cannot
take advantage of the fact that entries are sorted by pathname to
bisect to directly jump to an entry).
> If we knew that our deltas were always produced on entry-boundaries (a
> "character" in your description above), this would be much simpler.
;-)
> [2] One option, of course, is to generate byte-wise deltas, but with a
> promise to always align them on entry boundaries. I'm tempted by
> this, because the result would be readable by existing packv2
> readers. We'd have to set a flag somewhere that indicates the pack
> was written with this property, though.
Yes, that may work.
next prev parent reply other threads:[~2015-02-16 7:12 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-13 10:46 Pack v4 again Duy Nguyen
2015-02-16 4:59 ` Nicolas Pitre
2015-02-16 6:45 ` Jeff King
2015-02-16 7:12 ` Junio C Hamano [this message]
2015-02-16 10:48 ` Duy Nguyen
2015-02-17 4:12 ` Shawn Pearce
2015-02-16 10:11 ` Duy Nguyen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqlhjy72jr.fsf@gitster.dls.corp.google.com \
--to=gitster@pobox$(echo .)com \
--cc=git@vger$(echo .)kernel.org \
--cc=nico@fluxnic$(echo .)net \
--cc=pclouds@gmail$(echo .)com \
--cc=peff@peff$(echo .)net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox