public inbox for git@vger.kernel.org 
 help / color / mirror / Atom feed

From: Junio C Hamano <gitster@pobox•com>
To: Ramsay Jones <ramsay@ramsay1•demon.co.uk>
Cc: "Torsten Bögershausen" <tboegi@web•de>,
	git@vger•kernel.org, "Jonathan Nieder" <jrnieder@gmail•com>
Subject: Re: [PATCH RFC] CYGWIN: avoid implicit declaration warning
Date: Mon, 24 Nov 2014 14:50:01 -0800	[thread overview]
Message-ID: <xmqqlhn0usbq.fsf@gitster.dls.corp.google.com> (raw)
In-Reply-To: <5473B0E4.9090900@ramsay1.demon.co.uk> (Ramsay Jones's message of "Mon, 24 Nov 2014 22:27:48 +0000")

Ramsay Jones <ramsay@ramsay1•demon.co.uk> writes:

> ...
> Although I have not done an actual diff of the various cdef.h files, they
> do appear to be more or less the same. In other words, I no longer think
> that the change results from a 'change in priority of _XOPEN_SOURCE'. The
> issue is simply that in the old <string.h> header these functions were
> declared unconditionally; in the new headers the are contained within
> preprocessor conditionals using the __GNU_VISIBLE and __BSD_VISIBLE macros
> which are not set when _XOPEN_SOURCE is set (despite _GNU_SOURCE and
> _BSD_SOURCE being set).

So I can take your version [*1*], drop this bit from the log:

    This seems to be caused by a change to the system headers which
    results in the _XOPEN_SOURCE macro now having prioity over the
    _GNU_SOURCE and _BSD_SOURCE macros (they are simply ignored).
    This in turn leads to the declarations of the above functions
    to be suppressed.

and replace it with something like:

    <string.h> on Cygwin used to always declare the above functions,
    but a recent version of it no longer make them visible when
    _XOPEN_SOURCE is set (even if _GNU_SOURCE and _BSD_SOURCE is
    set).

and keep the rest, I think.

Thanks for digging this thoroughly.


[Reference]

*1* http://article.gmane.org/gmane.comp.version-control.git/260091

next prev parent reply	other threads:[~2014-11-24 22:50 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-11-23 14:16 [PATCH RFC] CYGWIN: avoid implicit declaration warning Torsten Bögershausen
2014-11-23 17:12 ` Ramsay Jones
2014-11-23 18:53   ` Junio C Hamano
2014-11-23 23:15     ` Ramsay Jones
2014-11-24  7:20       ` Torsten Bögershausen
2014-11-24 16:00         ` Torsten Bögershausen
2014-11-24 18:29           ` [PATCH] t5000 on Windows: do not mistake "sh.exe" as "sh" Johannes Sixt
2014-11-24 20:02             ` Torsten Bögershausen
2014-11-24 21:27         ` [PATCH RFC] CYGWIN: avoid implicit declaration warning Ramsay Jones
2014-11-24 21:44           ` Junio C Hamano
2014-11-24 22:59             ` Ramsay Jones
2014-11-24 22:27       ` Ramsay Jones
2014-11-24 22:50         ` Junio C Hamano [this message]
2014-11-24 23:04           ` Ramsay Jones
2014-11-24 17:59 ` Jonathan Nieder
2014-11-24 19:17   ` Torsten Bögershausen
2014-11-24 21:41   ` Ramsay Jones

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqqlhn0usbq.fsf@gitster.dls.corp.google.com \
    --to=gitster@pobox$(echo .)com \
    --cc=git@vger$(echo .)kernel.org \
    --cc=jrnieder@gmail$(echo .)com \
    --cc=ramsay@ramsay1$(echo .)demon.co.uk \
    --cc=tboegi@web$(echo .)de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox