public inbox for git@vger.kernel.org 
 help / color / mirror / Atom feed

From: Junio C Hamano <gitster@pobox•com>
To: Jeff King <peff@peff•net>
Cc: "René Scharfe" <l.s.r@web•de>,
	"Git Mailing List" <git@vger•kernel.org>,
	"Stefan Beller" <stefanbeller@gmail•com>
Subject: Re: [PATCH 2/3] make update-server-info more robust
Date: Mon, 15 Sep 2014 11:39:12 -0700	[thread overview]
Message-ID: <xmqqlhpk7mpb.fsf@gitster.dls.corp.google.com> (raw)
In-Reply-To: <20140913201920.GB27082@peff.net> (Jeff King's message of "Sat, 13 Sep 2014 16:19:20 -0400")

Jeff King <peff@peff•net> writes:

> Since "git update-server-info" may be called automatically
> as part of a push or a "gc --auto", we should be robust
> against two processes trying to update it simultaneously.
> However, we currently use a fixed tempfile, which means that
> two simultaneous writers may step on each other's toes and
> end up renaming junk into place.

Thanks.  I'll queue these clean-ups but we may want to start
thinking about deprecating and removing the dumb http support.

next prev parent reply	other threads:[~2014-09-15 18:39 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-09-13  7:28 [PATCH] repack: call prune_packed_objects() and update_server_info() directly René Scharfe
2014-09-13  8:59 ` Stefan Beller
2014-09-13 20:15 ` Jeff King
2014-09-13 20:16   ` [PATCH 1/3] prune-packed: fix minor memory leak Jeff King
2014-09-13 20:19   ` [PATCH 2/3] make update-server-info more robust Jeff King
2014-09-14 17:38     ` René Scharfe
2014-09-15 18:39     ` Junio C Hamano [this message]
2014-09-15 23:56       ` Jeff King
2014-09-13 20:19   ` [PATCH 3/3] server-info: clean up after writing info/packs Jeff King

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqqlhpk7mpb.fsf@gitster.dls.corp.google.com \
    --to=gitster@pobox$(echo .)com \
    --cc=git@vger$(echo .)kernel.org \
    --cc=l.s.r@web$(echo .)de \
    --cc=peff@peff$(echo .)net \
    --cc=stefanbeller@gmail$(echo .)com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox