Subject: Re: [PATCH v3 2/3] relative_path should honor DOS and UNC paths

From: Junio C Hamano <[email-masked]>
Date: Tue, 17 Sep 2013 09:12:20 -0700

Jiang Xin <[email-masked]> writes:

> diff --git a/compat/mingw.h b/compat/mingw.h
> index bd0a88b..06e9f49 100644
> --- a/compat/mingw.h
> +++ b/compat/mingw.h
> @@ -311,6 +311,15 @@ int winansi_fprintf(FILE *stream, const char *format, ...) __attribute__((format
>  
>  #define has_dos_drive_prefix(path) (isalpha(*(path)) && (path)[1] == ':')
>  #define is_dir_sep(c) ((c) == '/' || (c) == '\\')
> +static inline int is_unc_path(const char *path)
> +{
> +	if (!is_dir_sep(*path) || !is_dir_sep(*(path+1)) || is_dir_sep(*(path+2)))
> +		return 0;

If path[1] == '\0', it would be !is_dir_sep() and we end up
inspecting past the end of the string?