From: Junio C Hamano <gitster@pobox•com>
To: "brian m. carlson" <sandals@crustytoothpaste•net>
Cc: git@vger•kernel.org, artagnon@gmail•com, mst@redhat•com
Subject: Re: [PATCH] send-email: don't call methods on undefined values
Date: Mon, 09 Sep 2013 09:45:10 -0700 [thread overview]
Message-ID: <xmqqli363pwp.fsf@gitster.dls.corp.google.com> (raw)
In-Reply-To: <1378673674-97212-1-git-send-email-sandals@crustytoothpaste.net> (brian m. carlson's message of "Sun, 8 Sep 2013 20:54:34 +0000")
"brian m. carlson" <sandals@crustytoothpaste•net> writes:
> If SSL verification is enabled in git send-email, we could attempt to call a
> method on an undefined value if the verification failed, since $smtp would end
> up being undef. Look up the error string in a way that will produce a helpful
> error message and not cause further errors.
>
> Signed-off-by: brian m. carlson <sandals@crustytoothpaste•net>
> ---
> git-send-email.perl | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/git-send-email.perl b/git-send-email.perl
> index 2162478..3782c3b 100755
> --- a/git-send-email.perl
> +++ b/git-send-email.perl
> @@ -1234,7 +1234,7 @@ X-Mailer: git-send-email $gitversion
> if ($smtp->code == 220) {
> $smtp = Net::SMTP::SSL->start_SSL($smtp,
> ssl_verify_params())
> - or die "STARTTLS failed! ".$smtp->message;
> + or die "STARTTLS failed! ".IO::Socket::SSL::errstr();
I agree that $smtp->message may be bogus at this point, but could
"require IO::Socket::SSL" have failed on us in ssl_verify_params?
In that degraded mode, we do not do SSL peer verification, but
otherwise we would still attempt to talk with the peer, and in such
a case, IO::Socket::SSL would not be available to us at this point,
no?
> $smtp_encryption = '';
> # Send EHLO again to receive fresh
> # supported commands
next prev parent reply other threads:[~2013-09-09 16:45 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-08 20:54 [PATCH] send-email: don't call methods on undefined values brian m. carlson
2013-09-09 16:45 ` Junio C Hamano [this message]
2013-09-09 22:49 ` brian m. carlson
2013-09-13 6:09 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqli363pwp.fsf@gitster.dls.corp.google.com \
--to=gitster@pobox$(echo .)com \
--cc=artagnon@gmail$(echo .)com \
--cc=git@vger$(echo .)kernel.org \
--cc=mst@redhat$(echo .)com \
--cc=sandals@crustytoothpaste$(echo .)net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox