Subject: Re: [PATCH v5 06/10] diff: --patch-{grep,modifies} arg names for -G and -S

From: Junio C Hamano <[email-masked]>
Date: Wed, 12 Feb 2025 21:20:03 -0800

Illia Bobyr <[email-masked]> writes:

> Most arguments have both short and long versions.  Long versions are
> easier to read, especially in scripts and command history.
>
> This change mostly keeps existing uses of -G and -S as is in the tests,
> documentation and help output.
>
> Tests that check just the option parsing are duplicated to check both
> short and long argument options.
>
> Signed-off-by: Illia Bobyr <[email-masked]>
> ---

This step looks mostly good, but the option descriptions for
existing "-S" and "-G" have been touched by clean-up changes
earlier, so they cannot be separated out.

We can treat [01-05/10] as a separate 5-patch "preliminary
clean-up" series and discard this and later steps until the earlier
half lands.

Unlike other earlier steps, this one has a decent title and it has
your sign-off, both of which are good.  And of course it is very
much on topic.