From: Junio C Hamano <gitster@pobox•com>
To: "Martin Ågren" <martin.agren@gmail•com>
Cc: "Matthew Bystrin" <dev.mbstr@gmail•com>,
git@vger•kernel.org,
"Lessley Dennington" <lessleydennington@gmail•com>,
"Ævar Arnfjörð Bjarmason" <avarab@gmail•com>,
"Elijah Newren" <newren@gmail•com>,
"Phillip Wood" <phillip.wood123@gmail•com>,
"idriss fekir" <mcsm224@gmail•com>,
"Joey Salazar" <jgsal@protonmail•com>
Subject: Re: [PATCH] git: fix paginate handling for commands with DELAY_PAGER_CONFIG
Date: Sat, 23 Nov 2024 02:21:21 +0900 [thread overview]
Message-ID: <xmqqmshrrxpq.fsf@gitster.g> (raw)
In-Reply-To: <CAN0heSoryo-DO6WXKqqASJ5nDLqb3PNNiZv1TP=Pq11wsiSM6A@mail.gmail.com> ("Martin Ågren"'s message of "Thu, 21 Nov 2024 22:50:59 +0100")
Martin Ågren <martin.agren@gmail•com> writes:
> Hi Matthew,
> ...
> Actually, no, it's not so much ignoring as *forcing*. Since you force it
> to 0, doesn't that mean that `--paginate` ends up basically being
> `--no-pager`? So `git --paginate branch` is now `git --no-pager branch`?
> That doesn't seem right. An optionless `git branch` would have
> paginated, so adding `--paginate` shouldn't change anything.
>
> But even if we force it to -1 instead (for "maybe"), I'm not sure I
> understand why such an undoing of user intention is wanted. If I run
> `git --paginate tag -a ...`, maybe that's just self-inflicted harm, but
> are we certain that for all the `git foo --bar` which won't respect
> `pager.foo`, that it's also completely crazy to provide `--paginate`?
The whole thing started with
Calling commands using editor in terminal with `--paginate`
option will break things. For example `git --paginate config
--edit`.
which many of us may respond with "it hurts? do not do it then", so
I agree with you that a fallout would be worse than the problem the
change is trying to "fix".
next prev parent reply other threads:[~2024-11-22 17:21 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-20 10:17 [PATCH] git: fix paginate handling for commands with DELAY_PAGER_CONFIG Matthew Bystrin
2024-11-21 21:50 ` Martin Ågren
2024-11-22 17:21 ` Junio C Hamano [this message]
2024-11-22 18:13 ` Matthew Bystrin
2024-11-25 2:21 ` Junio C Hamano
2024-11-25 10:55 ` Martin Ågren
2024-11-28 22:27 ` Matthew Bystrin
2024-11-22 18:50 ` Kristoffer Haugsbakk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqmshrrxpq.fsf@gitster.g \
--to=gitster@pobox$(echo .)com \
--cc=avarab@gmail$(echo .)com \
--cc=dev.mbstr@gmail$(echo .)com \
--cc=git@vger$(echo .)kernel.org \
--cc=jgsal@protonmail$(echo .)com \
--cc=lessleydennington@gmail$(echo .)com \
--cc=martin.agren@gmail$(echo .)com \
--cc=mcsm224@gmail$(echo .)com \
--cc=newren@gmail$(echo .)com \
--cc=phillip.wood123@gmail$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox