Subject: Re: [PATCH v3 1/3] t4020: test exit code with external diffs

From: Junio C Hamano <[email-masked]>
Date: Mon, 10 Jun 2024 09:33:43 -0700

René Scharfe <[email-masked]> writes:

> +check_external_diff () {
> +	expect_code=$1
> +	expect_out=$2
> +	expect_err=$3
> +	command_code=$4
> +	shift 4
> +	options="$@"

Tiny nit, but I'd prefer to see "$@" reserved for its magic and all
other times where it is equivalent to "$*", see the latter used.

Other than that, all three patches looked good to me.  Thanks.