Subject: Re: [PATCH v2 2/2] osxkeychain: state[] seen=1 to skip unnecessary store operations

From: Junio C Hamano <[email-masked]>
Date: Sat, 11 May 2024 21:09:46 -0700

"Koji Nakamaru via GitGitGadget" <[email-masked]> writes:

> From: Koji Nakamaru <[email-masked]>
>
> Records whether credentials come from get operations and skips
> unnecessary store operations by utilizing the state[] feature, as
> suggested by brian m. carlson.

This step has a problem description that is even sketchier than the
previous one.  Anticipate questions by the other developers who read
this commit 6 months after it is accepted in the mainline (e.g.,
What problem is there in the current system, why it is bad and worth
solving, and how is the patch trying to solve it?) and let your
proposed log message answer the questions, as you won't be always
sitting next to these developers.

Thanks.