Subject: Re: [PATCH] tree-walk: disallow overflowing modes

From: Junio C Hamano <[email-masked]>
Date: Tue, 24 Jan 2023 12:44:16 -0800

René Scharfe <[email-masked]> writes:

> ...  It's basically harmless.  Perhaps
> we just need a comment stating that, to contain the urge to "fix" this.

Yeah, especially since fsck finds and warns about bad mode with
FSCK_MSG_BAD_FILEMODE and also FSCK_MSG_ZERO_PADDED_FILEMODE in a
separate codepath, adding another piece of code that checks a
slightly different condition does not sound like a good idea.

Thanks.