Subject: Re: [PATCH v3] git: edit variable types to match what is assigned to them

From: Junio C Hamano <[email-masked]>
Date: Sat, 17 Dec 2022 08:52:46 +0900

"Rose via GitGitGadget" <[email-masked]> writes:

> From: Seija Kijin <[email-masked]>
>
> There are many places where "int len = strlen(foo);" is written,
> just for len to be passed as a parameter of size_t.

True.

> This causes truncation and then expansion
> back from int to size_t.
>
> Not to mention, this is poor logic,
> and needless truncations can add
> extra unneeded instructions.

I'd omit the last paragraph if I were writing it, as these two
paragraphs saying exactly the same thing.