Subject: Re: [PATCH v10 3/9] grep tests: add missing "grep.patternType" config tests

From: Junio C Hamano <[email-masked]>
Date: Fri, 04 Feb 2022 15:03:15 -0800

Ævar Arnfjörð Bjarmason  <[email-masked]> writes:

> +	test_expect_success "grep $L with grep.extendedRegexp and grep.patternType are both last-one-wins independently (BRE)" '
> +		echo "${HC}ab:a+bc" >expected &&
> +		git \
> +			-c grep.patternType=default \
> +			-c grep.extendedRegexp=true \
> +			-c grep.patternType=basic \
> +			grep "a+b*c" $H ab >actual &&
> +		test_cmp expected actual
> +	'
> +	test_expect_success "grep $L with grep.patternType=extended and grep.patternType=default" '

Mising blank line between tests.

Other than that, this step looks good.

No need to resend; I'll fix this part up locally again.

Thanks.