From: Junio C Hamano <gitster@pobox•com>
To: "Ævar Arnfjörð Bjarmason" <avarab@gmail•com>
Cc: William Hubbs <williamh@gentoo•org>,
git@vger•kernel.org, chutzpah@gentoo•org
Subject: Re: [PATCH v2 1/2] config: allow giving separate author and committer idents
Date: Mon, 28 Jan 2019 13:33:12 -0800 [thread overview]
Message-ID: <xmqqmunka2nb.fsf@gitster-ct.c.googlers.com> (raw)
In-Reply-To: <871s4w4khs.fsf@evledraar.gmail.com> ("Ævar Arnfjörð Bjarmason"'s message of "Mon, 28 Jan 2019 21:04:15 +0100")
Ævar Arnfjörð Bjarmason <avarab@gmail•com> writes:
> I'm happy to help if you'd like. I had a thinko with "table", and I
> think our asciidoc dialect doesn't support it (maybe I'm wrong), but
> thinking about it again we could just describe these variables all in
> the same documentation. As in this hunk (which you could squash in):
>
> BEGIN QUOTE
> diff --git a/Documentation/config/user.txt b/Documentation/config/user.txt
> index 18e1ec3c1b..ad3c43cf47 100644
> --- a/Documentation/config/user.txt
> +++ b/Documentation/config/user.txt
> @@ -1,39 +1,20 @@
> +user.name::
> +user.email::
> author.name::
> +author.email::
> committer.name::
> +committer.email::
> + The `user.name` and `user.email` variables determine what ends
> + up in the `author` and `committer` field of commit
> + objects. These config variables will be overridden by
> + `GIT_COMMITTER_NAME` and `GIT_COMMITTER_EMAIL`,
You forgot to list two more obvious ones here.
> ++
> +Most users should have no reason to set the `author.*` and
> +`committer.*` variables, but can do so to e.g. set different a
> +different E-Mail for the `committer` field. Like the `user.name` and
> +`user.email` variables, these can be overridden in the environment
> +with `GIT_AUTHOR_NAME`, `GIT_AUTHOR_EMAIL`, `GIT_COMMITTER_NAME` and
> +`GIT_COMMITTER_EMAIL`.
I do not see a strong reason to say "most users should have no
reason", especially without arguing why (and I do not think this is
a place to make such an argument, either).
The `user.*` variables can be used to set both author and committer
names and e-mail addresses to the same value; users who want to set
the committer and author identities differently can use the
`author.*` and `committer.*` variables.
or something along that line, perhaps?
next prev parent reply other threads:[~2019-01-28 21:33 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-25 21:59 Add author and committer configuration settings William Hubbs
2019-01-25 21:59 ` [PATCH v2 1/2] config: allow giving separate author and committer idents William Hubbs
2019-01-25 22:58 ` Ævar Arnfjörð Bjarmason
2019-01-28 18:58 ` William Hubbs
2019-01-28 19:00 ` Junio C Hamano
2019-01-28 20:04 ` Ævar Arnfjörð Bjarmason
2019-01-28 21:33 ` Junio C Hamano [this message]
2019-01-28 23:30 ` William Hubbs
2019-01-29 22:42 ` William Hubbs
2019-01-25 21:59 ` [PATCH v2 2/2] tests: add test for " William Hubbs
2019-01-25 23:05 ` Ævar Arnfjörð Bjarmason
2019-01-26 1:06 ` William Hubbs
2019-01-26 8:53 ` Ævar Arnfjörð Bjarmason
2019-01-27 4:48 ` Eric Sunshine
2019-01-28 19:05 ` Ævar Arnfjörð Bjarmason
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqmunka2nb.fsf@gitster-ct.c.googlers.com \
--to=gitster@pobox$(echo .)com \
--cc=avarab@gmail$(echo .)com \
--cc=chutzpah@gentoo$(echo .)org \
--cc=git@vger$(echo .)kernel.org \
--cc=williamh@gentoo$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox