Subject: Re: [PATCH 16/22] sequencer: prepare for rebase -i's GPG settings

From: Junio C Hamano <[email-masked]>
Date: Wed, 31 Aug 2016 13:12:29 -0700

Jakub Narębski <[email-masked]> writes:

>> +			else {
>> +				opts->gpg_sign = buf.buf + 2;
>> +				strbuf_detach(&buf, NULL);
>
> Wouldn't we leak 2 characters that got skipped?  Maybe xstrdup would
> be better (if it is leaked, and not reattached)?

An attempt to avoid leaking by calling free(opts->gpg_sign) would
make it crash, which would be even worse ;-).