From: Junio C Hamano <gitster@pobox•com>
To: Johannes Schindelin <Johannes.Schindelin@gmx•de>
Cc: Johannes Sixt <j6t@kdbg•org>,
Git Mailing List <git@vger•kernel.org>,
git-for-windows <git-for-windows@googlegroups•com>
Subject: Re: [PATCH ew/daemon-socket-keepalive] Windows: add missing definition of ENOTSOCK
Date: Fri, 22 Jul 2016 12:28:19 -0700 [thread overview]
Message-ID: <xmqqmvl9a2wc.fsf@gitster.mtv.corp.google.com> (raw)
In-Reply-To: <alpine.DEB.2.20.1607221020520.14111@virtualbox> (Johannes Schindelin's message of "Fri, 22 Jul 2016 10:21:19 +0200 (CEST)")
Johannes Schindelin <Johannes.Schindelin@gmx•de> writes:
> Hi Hannes,
>
> On Thu, 21 Jul 2016, Johannes Sixt wrote:
>
>> The previous commit introduced the first use of ENOTSOCK. This macro is
>> not available on Windows. Define it as WSAENOTSOCK because that is the
>> corresponding error value reported by the Windows versions of socket
>> functions.
>
> Thanks for catching this early.
(is that an acked/reviewed-by? it is OK if it is not).
Yeah, thanks, both.
next prev parent reply other threads:[~2016-07-22 19:28 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-21 20:59 [PATCH ew/daemon-socket-keepalive] Windows: add missing definition of ENOTSOCK Johannes Sixt
2016-07-22 8:21 ` Johannes Schindelin
2016-07-22 19:28 ` Junio C Hamano [this message]
2016-07-23 8:02 ` Johannes Schindelin
2016-07-23 8:39 ` [PATCH v2 " Johannes Sixt
2016-07-22 19:31 ` [PATCH " Eric Wong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqmvl9a2wc.fsf@gitster.mtv.corp.google.com \
--to=gitster@pobox$(echo .)com \
--cc=Johannes.Schindelin@gmx$(echo .)de \
--cc=git-for-windows@googlegroups$(echo .)com \
--cc=git@vger$(echo .)kernel.org \
--cc=j6t@kdbg$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox