From: Junio C Hamano <gitster@pobox•com>
To: Jeff King <peff@peff•net>
Cc: git@vger•kernel.org, Johannes Schindelin <johannes.schindelin@gmx•de>
Subject: Re: [PATCH 1/2] t/perf: fix regression in testing older versions of git
Date: Wed, 22 Jun 2016 13:46:25 -0700 [thread overview]
Message-ID: <xmqqmvmdkl3y.fsf@gitster.mtv.corp.google.com> (raw)
In-Reply-To: <20160622194013.GA1697@sigill.intra.peff.net> (Jeff King's message of "Wed, 22 Jun 2016 15:40:13 -0400")
Jeff King <peff@peff•net> writes:
> So let's introduce a new variable, $MODERN_GIT, that we can
> use both in perf-lib and in the test setup to get a reliable
> set of git features (we might change git and break some
> tests, of course, but $MODERN_GIT is tied to the same
> version of git as the t/perf scripts, so they can be fixed
> or adjusted together).
I can see how this works for "git -C ... rev-parse ..." or any other
built-in commands, but I am not sure if this is sufficient when any
non-built-in command is used in the perf framework. How does it
interact with GIT_EXEC_PATH we set in ../test-lib.sh that is
dot-sourced by ./perf-lib.sh that everybody dot-sources?
next prev parent reply other threads:[~2016-06-22 20:46 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-22 19:39 [PATCH 0/2] t/perf tests against older versions Jeff King
2016-06-22 19:40 ` [PATCH 1/2] t/perf: fix regression in testing older versions of git Jeff King
2016-06-22 20:23 ` Johannes Schindelin
2016-06-22 20:25 ` Johannes Schindelin
2016-06-22 20:46 ` Junio C Hamano [this message]
2016-06-22 20:48 ` Jeff King
2016-06-22 20:51 ` Junio C Hamano
2016-06-22 19:40 ` [PATCH 2/2] p4211: explicitly disable renames in no-rename test Jeff King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqmvmdkl3y.fsf@gitster.mtv.corp.google.com \
--to=gitster@pobox$(echo .)com \
--cc=git@vger$(echo .)kernel.org \
--cc=johannes.schindelin@gmx$(echo .)de \
--cc=peff@peff$(echo .)net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox