From: Junio C Hamano <gitster@pobox•com>
To: Matthieu Moy <Matthieu.Moy@grenoble-inp•fr>
Cc: Mehul Jain <mehul.jain2029@gmail•com>,
git@vger•kernel.org, sunshine@sunshineco•com
Subject: Re: [PATCH v2 0/7] t5520: tests for --[no-]autostash option
Date: Mon, 04 Apr 2016 10:00:22 -0700 [thread overview]
Message-ID: <xmqqmvp95mxl.fsf@gitster.mtv.corp.google.com> (raw)
In-Reply-To: <vpqshz125jr.fsf@anie.imag.fr> (Matthieu Moy's message of "Mon, 04 Apr 2016 09:31:52 +0200")
Matthieu Moy <Matthieu.Moy@grenoble-inp•fr> writes:
> Mehul Jain <mehul.jain2029@gmail•com> writes:
>
>> -test_rebase_autostash () {
>> +test_pull_autostash () {
>> git reset --hard before-rebase &&
>> echo dirty >new_file &&
>> git add new_file &&
>> - git pull --rebase --autostash . copy &&
>> + git pull $@ . copy &&
>
> Not strictly needed here, but I'd write "$@" (with the double-quotes)
> which is the robust way to say "transmit all my arguments without
> whitespace interpretation".
Yes, these should be "$@" (with the double-quotes).
> I don't mind for this patch since there's no whitespace to interpret,
> but some people (sysadmins ;-) ) have the bad habit of writting $@, $*
> or "$*" in wrapper scripts and it breaks when you call them with spaces
> so it's better to take good habits IHMO.
next prev parent reply other threads:[~2016-04-04 17:00 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-02 17:58 [PATCH v2 0/7] t5520: tests for --[no-]autostash option Mehul Jain
2016-04-02 17:58 ` [PATCH v2 1/7] t5520: use consistent capitalization in test titles Mehul Jain
2016-04-02 17:58 ` [PATCH v2 2/7] t5520: ensure consistent test conditions Mehul Jain
2016-04-02 17:58 ` [PATCH v2 3/7] t5520: use better test to check stderr output Mehul Jain
2016-04-02 17:58 ` [PATCH v2 4/7] t5520: factor out common code Mehul Jain
2016-04-03 20:03 ` Eric Sunshine
2016-04-02 17:58 ` [PATCH v2 5/7] " Mehul Jain
2016-04-03 20:05 ` Eric Sunshine
2016-04-02 17:58 ` [PATCH v2 6/7] t5520: reduce commom lines of code Mehul Jain
2016-04-02 18:50 ` Johannes Sixt
2016-04-03 6:24 ` Mehul Jain
2016-04-03 6:46 ` Johannes Sixt
2016-04-02 17:58 ` [PATCH v2 7/7] t5520: test --[no-]autostash with pull.rebase=true Mehul Jain
2016-04-03 20:11 ` Eric Sunshine
2016-04-03 8:47 ` [PATCH v2 6/7] t5520: reduce commom lines of code Mehul Jain
2016-04-03 20:17 ` [PATCH v2 0/7] t5520: tests for --[no-]autostash option Eric Sunshine
2016-04-04 7:31 ` Matthieu Moy
2016-04-04 16:58 ` Mehul Jain
2016-04-04 17:00 ` Junio C Hamano [this message]
2016-04-04 17:07 ` Mehul Jain
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqmvp95mxl.fsf@gitster.mtv.corp.google.com \
--to=gitster@pobox$(echo .)com \
--cc=Matthieu.Moy@grenoble-inp$(echo .)fr \
--cc=git@vger$(echo .)kernel.org \
--cc=mehul.jain2029@gmail$(echo .)com \
--cc=sunshine@sunshineco$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox