From: Junio C Hamano <gitster@pobox•com>
To: Johannes Schindelin <johannes.schindelin@gmx•de>
Cc: git@vger•kernel.org
Subject: Re: [PATCH 00/19] Let Git's tests pass on Windows
Date: Sun, 24 Jan 2016 17:34:08 -0800 [thread overview]
Message-ID: <xmqqmvrubfxr.fsf@gitster.mtv.corp.google.com> (raw)
In-Reply-To: <cover.1453650173.git.johannes.schindelin@gmx.de> (Johannes Schindelin's message of "Sun, 24 Jan 2016 16:43:06 +0100 (CET)")
Johannes Schindelin <johannes.schindelin@gmx•de> writes:
> This is a big milestone. With these modifications, Git's source code
> does not only build without warnings in Git for Windows' SDK, but
> passes the entire regression test suite.
;-)
It is somewhat surprising that with only these changes my tree is no
longer behind the Git for Windows effort--all tests pass so everything
should be working perfectly, right ;-)
There were a few changes in the series that raised my eyebrows,
which I'll respond separately, but overall it's a great
achievement.
Thanks.
>
> The patch series contains three different types of patches. First,
> there are a couple of real fixes that were triggered by failures in
> the regression tests. Then there are a couple of fixes to the
> regression tests themselves. And finally, we have to disable a couple
> of tests because we simply cannot make them work on Windows.
>
>
> Johannes Schindelin (13):
> mingw: let's use gettext with MSYS2
> mingw: do not trust MSYS2's MinGW gettext.sh
> Git.pm: stop assuming that absolute paths start with a slash
> mingw: prepare the TMPDIR environment variable for shell scripts
> mingw: let lstat() fail with errno == ENOTDIR when appropriate
> mingw: fix t5601-clone.sh
> mingw: accomodate t0060-path-utils for MSYS2
> mingw: disable mkfifo-based tests
> tests: turn off git-daemon tests if FIFOs are not available
> mingw: fix t9700's assumption about directory separators
> mingw: work around pwd issues in the tests
> mingw: skip a couple of git-svn tests that cannot pass on Windows
> mingw: do not bother to test funny file names
>
> Karsten Blees (2):
> mingw: factor out Windows specific environment setup
> mingw: do not use symlinks with SVN in t9100
>
> Pat Thoyts (1):
> mingw: avoid absolute path in t0008
>
> Thomas Braun (1):
> mingw: outsmart MSYS2's path substitution in t1508
>
> 마누엘 (2):
> mingw: try to delete target directory before renaming
> mingw: fix git-svn tests that expect chmod to work
>
> Makefile | 1 +
> compat/mingw.c | 91 +++++++++++++++++++++++++++++------
> config.mak.uname | 3 +-
> perl/Git.pm | 3 +-
> t/lib-git-daemon.sh | 5 ++
> t/t0008-ignores.sh | 8 ++-
> t/t0060-path-utils.sh | 37 ++++++++------
> t/t1508-at-combinations.sh | 13 ++++-
> t/t3300-funny-names.sh | 1 +
> t/t3600-rm.sh | 3 +-
> t/t3703-add-magic-pathspec.sh | 2 +-
> t/t3902-quoted.sh | 1 +
> t/t4016-diff-quote.sh | 1 +
> t/t4135-apply-weird-filenames.sh | 3 +-
> t/t5601-clone.sh | 18 +++----
> t/t7800-difftool.sh | 14 +++---
> t/t9100-git-svn-basic.sh | 29 +++++++----
> t/t9118-git-svn-funky-branch-names.sh | 12 +++--
> t/t9124-git-svn-dcommit-auto-props.sh | 20 ++++++--
> t/t9130-git-svn-authors-file.sh | 2 +-
> t/t9200-git-cvsexportcommit.sh | 2 +-
> t/t9400-git-cvsserver-server.sh | 6 +--
> t/t9401-git-cvsserver-crlf.sh | 6 +--
> t/t9402-git-cvsserver-refs.sh | 6 +--
> t/t9700/test.pl | 2 +-
> t/t9903-bash-prompt.sh | 2 +-
> t/test-lib.sh | 2 +-
> test-fake-ssh.c | 30 ++++++++++++
> 28 files changed, 238 insertions(+), 85 deletions(-)
> create mode 100644 test-fake-ssh.c
next prev parent reply other threads:[~2016-01-25 1:34 UTC|newest]
Thread overview: 113+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-24 15:43 [PATCH 00/19] Let Git's tests pass on Windows Johannes Schindelin
2016-01-24 15:43 ` [PATCH 01/19] mingw: let's use gettext with MSYS2 Johannes Schindelin
2016-01-25 1:42 ` Junio C Hamano
2016-01-25 16:16 ` Johannes Schindelin
2016-01-25 18:53 ` Junio C Hamano
2016-01-24 15:43 ` [PATCH 02/19] mingw: do not trust MSYS2's MinGW gettext.sh Johannes Schindelin
2016-01-24 15:43 ` [PATCH 03/19] Git.pm: stop assuming that absolute paths start with a slash Johannes Schindelin
2016-01-24 15:43 ` [PATCH 04/19] mingw: factor out Windows specific environment setup Johannes Schindelin
2016-01-24 15:43 ` [PATCH 05/19] mingw: prepare the TMPDIR environment variable for shell scripts Johannes Schindelin
2016-01-25 2:11 ` Eric Sunshine
2016-01-26 8:38 ` Johannes Schindelin
2016-01-24 15:44 ` [PATCH 06/19] mingw: try to delete target directory before renaming Johannes Schindelin
2016-01-24 17:42 ` Philip Oakley
2016-01-25 6:59 ` Johannes Schindelin
2016-01-25 18:55 ` Junio C Hamano
2016-01-26 8:14 ` Johannes Schindelin
2016-01-24 15:44 ` [PATCH 07/19] mingw: let lstat() fail with errno == ENOTDIR when appropriate Johannes Schindelin
2016-01-24 15:44 ` [PATCH 08/19] mingw: fix t5601-clone.sh Johannes Schindelin
2016-01-24 15:44 ` [PATCH 09/19] mingw: accomodate t0060-path-utils for MSYS2 Johannes Schindelin
2016-01-24 19:51 ` Johannes Sixt
2016-01-25 15:39 ` Johannes Schindelin
2016-01-24 15:44 ` [PATCH 10/19] mingw: disable mkfifo-based tests Johannes Schindelin
2016-01-24 15:44 ` [PATCH 11/19] tests: turn off git-daemon tests if FIFOs are not available Johannes Schindelin
2016-01-24 15:45 ` [PATCH 12/19] mingw: do not use symlinks with SVN in t9100 Johannes Schindelin
2016-01-25 1:51 ` Junio C Hamano
2016-01-25 16:53 ` Johannes Schindelin
2016-01-24 15:45 ` [PATCH 13/19] mingw: outsmart MSYS2's path substitution in t1508 Johannes Schindelin
2016-01-25 2:03 ` Junio C Hamano
2016-01-25 6:22 ` Eric Sunshine
2016-01-25 18:50 ` Junio C Hamano
2016-01-26 6:53 ` Johannes Schindelin
2016-01-25 16:30 ` Johannes Schindelin
2016-01-25 17:04 ` Johannes Schindelin
2016-01-24 15:45 ` [PATCH 14/19] mingw: fix t9700's assumption about directory separators Johannes Schindelin
2016-01-24 15:45 ` [PATCH 15/19] mingw: work around pwd issues in the tests Johannes Schindelin
2016-01-24 15:45 ` [PATCH 16/19] mingw: avoid absolute path in t0008 Johannes Schindelin
2016-01-25 2:11 ` Junio C Hamano
2016-01-25 16:48 ` Johannes Schindelin
2016-01-25 19:31 ` Ray Donnelly
2016-01-25 22:20 ` Junio C Hamano
2016-01-26 8:00 ` Johannes Schindelin
2016-01-24 15:45 ` [PATCH 17/19] mingw: fix git-svn tests that expect chmod to work Johannes Schindelin
2016-01-25 2:14 ` Junio C Hamano
2016-01-26 6:31 ` Johannes Schindelin
2016-01-26 17:42 ` Junio C Hamano
2016-01-24 15:45 ` [PATCH 18/19] mingw: skip a couple of git-svn tests that cannot pass on Windows Johannes Schindelin
2016-01-25 2:16 ` Junio C Hamano
2016-01-26 6:45 ` Johannes Schindelin
2016-01-24 15:45 ` [PATCH 19/19] mingw: do not bother to test funny file names Johannes Schindelin
2016-01-25 1:34 ` Junio C Hamano [this message]
2016-01-25 15:45 ` [PATCH 00/19] Let Git's tests pass on Windows Johannes Schindelin
2016-01-26 14:34 ` [PATCH v2 " Johannes Schindelin
2016-01-26 14:34 ` [PATCH v2 01/19] mingw: let's use gettext with MSYS2 Johannes Schindelin
2016-01-26 14:34 ` [PATCH v2 02/19] mingw: do not trust MSYS2's MinGW gettext.sh Johannes Schindelin
2016-01-26 14:34 ` [PATCH v2 03/19] Git.pm: stop assuming that absolute paths start with a slash Johannes Schindelin
2016-01-26 14:34 ` [PATCH v2 04/19] mingw: factor out Windows specific environment setup Johannes Schindelin
2016-01-26 14:34 ` [PATCH v2 05/19] mingw: prepare the TMPDIR environment variable for shell scripts Johannes Schindelin
2016-01-26 14:34 ` [PATCH v2 06/19] mingw: try to delete target directory before renaming Johannes Schindelin
2016-01-26 14:34 ` [PATCH v2 07/19] mingw: let lstat() fail with errno == ENOTDIR when appropriate Johannes Schindelin
2016-01-26 14:34 ` [PATCH v2 08/19] mingw: fix t5601-clone.sh Johannes Schindelin
2016-01-26 14:35 ` [PATCH v2 09/19] mingw: accomodate t0060-path-utils for MSYS2 Johannes Schindelin
2016-01-26 14:35 ` [PATCH v2 10/19] mingw: disable mkfifo-based tests Johannes Schindelin
2016-01-26 14:35 ` [PATCH v2 11/19] tests: turn off git-daemon tests if FIFOs are not available Johannes Schindelin
2016-01-26 14:35 ` [PATCH v2 12/19] mingw: skip test in t1508 that fails due to path conversion Johannes Schindelin
2016-01-26 22:02 ` Junio C Hamano
2016-01-27 8:50 ` Johannes Schindelin
2016-01-27 20:23 ` Junio C Hamano
2016-01-28 7:58 ` Johannes Schindelin
2016-01-26 14:35 ` [PATCH v2 13/19] mingw: fix t9700's assumption about directory separators Johannes Schindelin
2016-01-26 14:35 ` [PATCH v2 14/19] mingw: work around pwd issues in the tests Johannes Schindelin
2016-01-26 14:35 ` [PATCH v2 15/19] Avoid absolute path in t0008 Johannes Schindelin
2016-01-26 14:35 ` [PATCH v2 16/19] mingw: mark t9100's test cases with appropriate prereqs Johannes Schindelin
2016-01-26 21:50 ` Junio C Hamano
2016-01-27 16:02 ` Johannes Schindelin
2016-01-26 14:35 ` [PATCH v2 17/19] mingw: avoid illegal filename in t9118 Johannes Schindelin
2016-01-26 14:35 ` [PATCH v2 18/19] mingw: handle the missing POSIXPERM prereq in t9124 Johannes Schindelin
2016-01-26 22:05 ` Junio C Hamano
2016-01-27 9:20 ` Johannes Schindelin
2016-01-26 14:35 ` [PATCH v2 19/19] mingw: do not bother to test funny file names Johannes Schindelin
2016-01-26 20:03 ` Eric Sunshine
2016-01-26 20:24 ` Junio C Hamano
2016-01-27 8:33 ` Johannes Schindelin
2016-01-26 22:12 ` [PATCH v2 00/19] Let Git's tests pass on Windows Junio C Hamano
2016-01-27 8:38 ` Johannes Schindelin
2016-01-27 20:24 ` Junio C Hamano
2016-01-27 16:19 ` [PATCH v3 00/20] " Johannes Schindelin
2016-01-27 16:19 ` [PATCH v3 01/20] mingw: let's use gettext with MSYS2 Johannes Schindelin
2016-01-27 16:19 ` [PATCH v3 02/20] mingw: do not trust MSYS2's MinGW gettext.sh Johannes Schindelin
2016-01-27 16:19 ` [PATCH v3 03/20] Git.pm: stop assuming that absolute paths start with a slash Johannes Schindelin
2016-01-27 16:19 ` [PATCH v3 04/20] mingw: factor out Windows specific environment setup Johannes Schindelin
2016-01-27 16:19 ` [PATCH v3 05/20] mingw: prepare the TMPDIR environment variable for shell scripts Johannes Schindelin
2016-01-27 16:19 ` [PATCH v3 06/20] mingw: try to delete target directory before renaming Johannes Schindelin
2016-01-27 16:19 ` [PATCH v3 07/20] mingw: let lstat() fail with errno == ENOTDIR when appropriate Johannes Schindelin
2016-01-27 16:19 ` [PATCH v3 08/20] mingw: fix t5601-clone.sh Johannes Schindelin
2016-01-27 16:19 ` [PATCH v3 09/20] mingw: accomodate t0060-path-utils for MSYS2 Johannes Schindelin
2016-01-27 16:19 ` [PATCH v3 10/20] mingw: disable mkfifo-based tests Johannes Schindelin
2016-01-27 16:19 ` [PATCH v3 11/20] tests: turn off git-daemon tests if FIFOs are not available Johannes Schindelin
2016-01-28 8:21 ` Eric Sunshine
2016-01-28 8:40 ` Johannes Schindelin
2016-01-28 21:35 ` Junio C Hamano
2016-01-27 16:19 ` [PATCH v3 12/20] mingw: skip test in t1508 that fails due to path conversion Johannes Schindelin
2016-01-27 16:19 ` [PATCH v3 13/20] mingw: fix t9700's assumption about directory separators Johannes Schindelin
2016-01-27 16:19 ` [PATCH v3 14/20] mingw: work around pwd issues in the tests Johannes Schindelin
2016-01-27 16:20 ` [PATCH v3 15/20] Avoid absolute path in t0008 Johannes Schindelin
2016-01-27 16:20 ` [PATCH v3 16/20] mingw: mark t9100's test cases with appropriate prereqs Johannes Schindelin
2016-01-27 16:33 ` Johannes Schindelin
2016-01-27 16:20 ` [PATCH v3 17/20] mingw: avoid illegal filename in t9118 Johannes Schindelin
2016-01-27 16:20 ` [PATCH v3 18/20] mingw: handle the missing POSIXPERM prereq in t9124 Johannes Schindelin
2016-01-27 16:20 ` [PATCH v3 19/20] mingw: skip a test in t9130 that cannot pass on Windows Johannes Schindelin
2016-01-27 16:20 ` [PATCH v3 20/20] mingw: do not bother to test funny file names Johannes Schindelin
2016-01-28 8:42 ` [PATCH v3 00/20] Let Git's tests pass on Windows Eric Sunshine
2016-01-28 8:57 ` Johannes Schindelin
2016-01-28 21:37 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqmvrubfxr.fsf@gitster.mtv.corp.google.com \
--to=gitster@pobox$(echo .)com \
--cc=git@vger$(echo .)kernel.org \
--cc=johannes.schindelin@gmx$(echo .)de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox