From: Junio C Hamano <gitster@pobox•com>
To: Lars Schneider <larsxschneider@gmail•com>
Cc: Luke Diamand <luke@diamand•org>, git@vger•kernel.org
Subject: Re: [PATCH v2 1/4] git-p4: add optional type specifier to gitConfig reader
Date: Thu, 03 Sep 2015 13:18:51 -0700 [thread overview]
Message-ID: <xmqqmvx3i7dg.fsf@gitster.mtv.corp.google.com> (raw)
In-Reply-To: <A76D6BC6-E0AD-48F4-AE33-80BD0803BFA3@gmail.com> (Lars Schneider's message of "Thu, 3 Sep 2015 22:14:32 +0200")
Lars Schneider <larsxschneider@gmail•com> writes:
> On 03 Sep 2015, at 21:55, Luke Diamand <luke@diamand•org> wrote:
>
>> On 03/09/15 17:35, larsxschneider@gmail•com wrote:
>>> From: Lars Schneider <larsxschneider@gmail•com>
>>>
>>
>> I think this commit may need some explanation!
>
> The functions “gitConfig” and “gitConfigBool” are almost
> identical. Make “gitConfig” more generic by adding an optional type
> specifier. Use the type specifier “—bool” with “gitConfig” to
> implement “gitConfigBool. This prepares the implementation of other
> type specifiers such as “—int”.
OK.
> OK?
Not really ;-). The point of Luke's message is that all of the
above belong to the log message, I think.
next prev parent reply other threads:[~2015-09-03 20:18 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-03 16:35 [PATCH v2] git-p4: add support for large file systems larsxschneider
2015-09-03 16:35 ` [PATCH v2 1/4] git-p4: add optional type specifier to gitConfig reader larsxschneider
2015-09-03 19:55 ` Luke Diamand
2015-09-03 20:14 ` Lars Schneider
2015-09-03 20:18 ` Junio C Hamano [this message]
2015-09-03 20:53 ` Lars Schneider
2015-09-03 21:31 ` Junio C Hamano
2015-09-04 7:49 ` Lars Schneider
2015-09-03 16:35 ` [PATCH v2 2/4] git-p4: add gitConfigInt reader larsxschneider
2015-09-03 19:57 ` Luke Diamand
2015-09-03 20:17 ` Lars Schneider
2015-09-03 20:20 ` Luke Diamand
2015-09-03 16:35 ` [PATCH v2 3/4] git-p4: return an empty list if a list config has no values larsxschneider
2015-09-03 16:35 ` [PATCH v2 4/4] git-p4: add support for large file systems larsxschneider
2015-09-03 20:03 ` Luke Diamand
2015-09-03 20:49 ` Lars Schneider
2015-09-04 8:58 ` Jeff King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqmvx3i7dg.fsf@gitster.mtv.corp.google.com \
--to=gitster@pobox$(echo .)com \
--cc=git@vger$(echo .)kernel.org \
--cc=larsxschneider@gmail$(echo .)com \
--cc=luke@diamand$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox