public inbox for git@vger.kernel.org 
 help / color / mirror / Atom feed

From: Junio C Hamano <gitster@pobox•com>
To: Eric Sunshine <sunshine@sunshineco•com>
Cc: git@vger•kernel.org, "Renato Botelho" <garga@freebsd•org>,
	"Sébastien Guimmara" <sebastien.guimmara@gmail•com>
Subject: Re: [PATCH] generate-cmdlist: re-implement as shell script
Date: Thu, 20 Aug 2015 10:24:26 -0700	[thread overview]
Message-ID: <xmqqmvxl7u0l.fsf@gitster.dls.corp.google.com> (raw)
In-Reply-To: <1440015528-7791-1-git-send-email-sunshine@sunshineco.com> (Eric Sunshine's message of "Wed, 19 Aug 2015 16:18:48 -0400")

Eric Sunshine <sunshine@sunshineco•com> writes:

> diff --git a/generate-cmdlist.sh b/generate-cmdlist.sh
> new file mode 100755
> index 0000000..1ac329d
> --- /dev/null
> +++ b/generate-cmdlist.sh
> @@ -0,0 +1,50 @@
> +#!/bin/sh
> +
> +echo "/* Automatically generated by $0 */
> +struct cmdname_help {
> +	char name[16];
> +	char help[80];
> +	unsigned char group;
> +};
> +
> +static const char *common_cmd_groups[] = {"
> +
> +tmp=cmdgrps$$.tmp
> +trap "rm -fr $tmp" 0 1 2 3 15
> +
> +sed -n '
> +	1,/^### common groups/b
> +	/^### command list/q
> +	/^#/d; /^[ 	]*$/b
> +	h;s/^[^ 	][^ 	]*[ 	][ 	]*\(.*\)/	N_("\1"),/p
> +	g;s/^\([^ 	][^ 	]*\)[ 	].*/\1/w '$tmp'
> +	'
> +printf '};\n\n'

Unfortunately, this does not seem to work for me.  Even though sed
stops reading after seeing the "### command list" line, I suspect
that its stdin buffer has been filled with other lines that follow
it from the input to the buffer size, consuming what you meant to
feed the later 'grep $matchgrp"' with.

This is a one-time thing, so I do not mind to update the Makefile
so that it does not feed command-list.txt from the standard input
but gives the path as "$1" to this script.

> +n=0
> +matchgrp=
> +substnum=
> +while read grp
> +do
> +	matchgrp="$matchgrp${matchgrp:+
> +}^git-..*[ 	]$grp"
> +	substnum="$substnum${substnum:+;}s/[ 	]$grp/$n/"
> +	n=$(($n+1))
> +done <$tmp
> +
> +printf 'static struct cmdname_help common_cmds[] = {\n'
> +grep "$matchgrp" |
> +sed 's/^git-//' |
> +sort |
> +while read cmd tags
> +do
> +	tag=$(echo $tags | sed "$substnum; s/[^0-9]//g")
> +	sed -n '
> +		/^NAME/,/git-'"$cmd"'/H
> +		${
> +			x
> +			s/.*git-'"$cmd"' - \(.*\)/	{"'"$cmd"'", N_("\1"), '$tag'},/
> +			p
> +		}' "Documentation/git-$cmd.txt"
> +done
> +echo "};"

next prev parent reply	other threads:[~2015-08-20 17:24 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-08-19 20:18 [PATCH] generate-cmdlist: re-implement as shell script Eric Sunshine
2015-08-19 22:38 ` Junio C Hamano
2015-08-20 18:11   ` Eric Sunshine
2015-08-20 17:24 ` Junio C Hamano [this message]
2015-08-20 18:18   ` Eric Sunshine

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqqmvxl7u0l.fsf@gitster.dls.corp.google.com \
    --to=gitster@pobox$(echo .)com \
    --cc=garga@freebsd$(echo .)org \
    --cc=git@vger$(echo .)kernel.org \
    --cc=sebastien.guimmara@gmail$(echo .)com \
    --cc=sunshine@sunshineco$(echo .)com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox