Subject: Re: [PATCH 04/17] Makefile: a dry-run can error out if no perl. Document the issue

From: Junio C Hamano <[email-masked]>
Date: Thu, 25 Jun 2015 13:21:17 -0700

"Philip Oakley" <[email-masked]> writes:

> From: "Junio C Hamano" <[email-masked]>
>>
>> I am not sure what this patch is trying to achieve.
>
> It was probably a bit of 'don't mess with working code', given that
> I'd used the NO_PERL solution, rather 'document the issue'....

Then this part applies, I think.

>> If you are not touching what this Makefile actually does, then I
>> would imagine that you are running the "buildsystems code" that
>> actually drives 'make -n' with some "available solution" (perhaps
>> you are running 'make -n NO_PERL=NoThanks' or something like that)?
>> Then instead of a command like this that nobody would read in this
>> file, the same command can instead go there to explain what the
>> "workaround" (e.g. unusual-looking 'make -n NO_PERL=NoThanks') is
>> doing?

Thanks.

-- 
-- 
*** Please reply-to-all at all times ***
*** (do not pretend to know who is subscribed and who is not) ***
*** Please avoid top-posting. ***
The msysGit Wiki is here: https://github.com/msysgit/msysgit/wiki - Github accounts are free.

You received this message because you are subscribed to the Google
Groups "msysGit" group.
To post to this group, send email to [email-masked]
To unsubscribe from this group, send email to
[email-masked]
For more options, and view previous threads, visit this group at
http://groups.google.com/group/msysgit?hl=en_US?hl=en

--- 
You received this message because you are subscribed to the Google Groups "Git for Windows" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [email-masked].
For more options, visit https://groups.google.com/d/optout.