public inbox for git@vger.kernel.org 
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox•com>
To: Jeff King <peff@peff•net>
Cc: Trevor Saunders <tbsaunde@tbsaunde•org>,
	Stefan Beller <sbeller@google•com>,
	"git\@vger.kernel.org" <git@vger•kernel.org>
Subject: Re: [PATCH] bisect: print abbrev sha1 for first bad commit
Date: Sun, 10 May 2015 21:33:02 -0700	[thread overview]
Message-ID: <xmqqmw1bg2dd.fsf@gitster.dls.corp.google.com> (raw)
In-Reply-To: <20150511011009.GA21830@peff.net> (Jeff King's message of "Sun, 10 May 2015 21:10:09 -0400")

Jeff King <peff@peff•net> writes:

> I'd argue for simply never showing the diff (dropping the "opt.diff = 1"
> line from bisect.c:show_diff_tree), but that is mostly my personal
> opinion.

Yeah, I think that is sensible. It may even be OK to just give a
"log --oneline".  

  reply	other threads:[~2015-05-11  4:33 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-05-08 23:46 [PATCH] bisect: print abbrev sha1 for first bad commit Trevor Saunders
2015-05-09  0:29 ` Stefan Beller
2015-05-09  2:03   ` Trevor Saunders
2015-05-09  4:07     ` Jeff King
2015-05-10 23:12       ` Trevor Saunders
2015-05-11  1:10         ` Jeff King
2015-05-11  4:33           ` Junio C Hamano [this message]
2015-05-11  7:38             ` Christian Couder
2015-05-11 16:54               ` Junio C Hamano
2015-05-11 18:17                 ` Trevor Saunders
2015-05-11 18:28                   ` Stefan Beller
2015-05-12  9:21                 ` Christian Couder
2015-05-12 17:11                   ` Junio C Hamano
2015-05-12 20:43                     ` Christian Couder
2015-05-12 20:58                       ` Stefan Beller
2015-05-12 23:40                         ` Trevor Saunders
2015-05-13 13:24                           ` Christian Couder

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqqmw1bg2dd.fsf@gitster.dls.corp.google.com \
    --to=gitster@pobox$(echo .)com \
    --cc=git@vger$(echo .)kernel.org \
    --cc=peff@peff$(echo .)net \
    --cc=sbeller@google$(echo .)com \
    --cc=tbsaunde@tbsaunde$(echo .)org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox