From: Junio C Hamano <gitster@pobox•com>
To: karthik nayak <karthik.188@gmail•com>
Cc: git@vger•kernel.org, sunshine@sunshineco•com
Subject: Re: [PATCH v5 1/2] sha1_file.c: support reading from a loose object of unknown type
Date: Wed, 25 Mar 2015 13:32:08 -0700 [thread overview]
Message-ID: <xmqqmw3024zb.fsf@gitster.dls.corp.google.com> (raw)
In-Reply-To: <55131885.5000706@gmail.com> (karthik nayak's message of "Thu, 26 Mar 2015 01:50:21 +0530")
karthik nayak <karthik.188@gmail•com> writes:
> I hope you meant the former.
I did mean the latter, which spends more lines without much
information (i.e. only closing braces), only to reduce the
duplication of two simple lines.
But you are right, I did miss the distinction between hdrbuf.buf and
hdr, so they are not identically duplicated.
next prev parent reply other threads:[~2015-03-25 20:32 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-25 7:19 [PATCH v5 0/2] cat-file: add a '--literally' option karthik nayak
2015-03-25 7:21 ` [PATCH v5 1/2] sha1_file.c: support reading from a loose object of unknown type Karthik Nayak
2015-03-25 19:13 ` Junio C Hamano
2015-03-25 20:20 ` karthik nayak
2015-03-25 20:32 ` Junio C Hamano [this message]
2015-03-25 19:27 ` Junio C Hamano
2015-03-25 20:22 ` karthik nayak
2015-03-25 7:22 ` [PATCH v5 2/2] cat-file: teach cat-file a '--literally' option Karthik Nayak
2015-03-25 7:42 ` Eric Sunshine
2015-03-25 7:48 ` karthik nayak
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqmw3024zb.fsf@gitster.dls.corp.google.com \
--to=gitster@pobox$(echo .)com \
--cc=git@vger$(echo .)kernel.org \
--cc=karthik.188@gmail$(echo .)com \
--cc=sunshine@sunshineco$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox