Subject: Re: [PATCH 11/24] untracked cache: load from UNTR index extension

From: Junio C Hamano <[email-masked]>
Date: Mon, 09 Feb 2015 14:26:13 -0800

Nguyễn Thái Ngọc Duy  <[email-masked]> writes:

> +static int read_one_dir(struct untracked_cache_dir **untracked_,
> +			struct read_data *rd)
> +{
> +#define NEXT(x) \
> +	next = data + (x); \
> +	if (next > rd->end) \
> +		return -1;

Please do not do this, and instead write them at two places they are
used.  It is not clear to those who are reading the use sites that
this can break the control flow and return to the caller.