From: Junio C Hamano <gitster@pobox•com>
To: Johan Herland <johan@herland•net>
Cc: Eric Sunshine <sunshine@sunshineco•com>,
Michael Blume <blume.mike@gmail•com>,
Git List <git@vger•kernel.org>
Subject: Re: mac test failure -- test 3301
Date: Tue, 11 Nov 2014 07:58:51 -0800 [thread overview]
Message-ID: <xmqqmw7x7mpw.fsf@gitster.dls.corp.google.com> (raw)
In-Reply-To: <CALKQrgexnrCy-P6yTZB+U0--5peaTys9KqB+KGKqbAuyLA=NqA@mail.gmail.com> (Johan Herland's message of "Tue, 11 Nov 2014 02:40:19 +0100")
Johan Herland <johan@herland•net> writes:
> Ah, thanks!
>
> I thought that quoting command output was a good idea in general. Am I
> wrong, or is this just one exception to an otherwise good guideline?
It is not a good practice to blindly follow any guideline ;-).
When you anticipate that different platforms throw you unnecessary
spaces around a single token you expect to see, not quoting is
obviously the right thing. If you are unsure if the comamand gives
you one or multiple tokens, you obviously risk the output getting
split by not quoting.
prev parent reply other threads:[~2014-11-11 15:58 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-11 0:17 mac test failure -- test 3301 Michael Blume
2014-11-11 0:23 ` Michael Blume
2014-11-11 0:46 ` Michael Blume
2014-11-11 1:19 ` Eric Sunshine
2014-11-11 1:40 ` Johan Herland
2014-11-11 1:46 ` Michael Blume
2014-11-11 2:41 ` Jeff King
2014-11-11 23:57 ` Johan Herland
2014-11-11 15:58 ` Junio C Hamano [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqmw7x7mpw.fsf@gitster.dls.corp.google.com \
--to=gitster@pobox$(echo .)com \
--cc=blume.mike@gmail$(echo .)com \
--cc=git@vger$(echo .)kernel.org \
--cc=johan@herland$(echo .)net \
--cc=sunshine@sunshineco$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox