public inbox for git@vger.kernel.org 
 help / color / mirror / Atom feed

From: Junio C Hamano <gitster@pobox•com>
To: Tanay Abhra <tanayabh@gmail•com>
Cc: Matthieu Moy <Matthieu.Moy@grenoble-inp•fr>,
	git@vger•kernel.org, Ramkumar Ramachandra <artagnon@gmail•com>
Subject: Re: [PATCH v2 5/6] config: add `git_die_config()` to the config-set API
Date: Fri, 25 Jul 2014 10:29:02 -0700	[thread overview]
Message-ID: <xmqqmwbx73fl.fsf@gitster.dls.corp.google.com> (raw)
In-Reply-To: <53D265DA.8070702@gmail.com> (Tanay Abhra's message of "Fri, 25 Jul 2014 19:42:42 +0530")

Tanay Abhra <tanayabh@gmail•com> writes:

> On 7/25/2014 7:33 PM, Matthieu Moy wrote:
>> Tanay Abhra <tanayabh@gmail•com> writes:
>> 
>>> --- a/config.c
>>> +++ b/config.c
>>> @@ -1403,11 +1403,12 @@ const struct string_list *git_configset_get_value_multi(struct config_set *cs, c
>>>  
>>>  int git_configset_get_string_const(struct config_set *cs, const char *key, const char **dest)
>>>  {
>>> -	const char *value;
>>> -	if (!git_configset_get_value(cs, key, &value))
>>> -		return git_config_string(dest, key, value);
>>> -	else
>>> -		return 1;
>>> +	int ret;
>>> +	char *value;
>>> +	ret = git_configset_get_string(cs, key, &value);
>>> +	if (ret <= 0)
>>> +		*dest = (const char*)value;
>>> +	return ret;
>>>  }
>> 
>> Isn't this a fixup meant for another series?
>>
>
> Though v12 is in pu, Junio commented that git_configset_get_string_const() &
> git_configset_get_string() can be done more concisely, I was trying to do
> that but I failed.

My comment on that version was not about conciseness.  You had one
that called git_config_string() to let the callee do the nonbool
error handling and xstrdup() of the non-error return value, and the
other one that did exactly what a call to git_config_string() would
have done.  That is being redundant, not just failing to be concise.

I was actually hoping that we would see just

int git_configset_get_string(struct config_set *cs, const char *key, char **dest)
{
	return git_configset_get_string_const(cs, key, (const char **)dest);
}

with the implementation of _const() variant be the one from v12.

next prev parent reply	other threads:[~2014-07-25 17:29 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-07-25 12:58 [PATCH v2 0/6] Rewrite `git_config()` using config-set API Tanay Abhra
2014-07-25 12:58 ` [PATCH v2 1/6] config.c: fix accuracy of line number in errors Tanay Abhra
2014-07-25 12:58 ` [PATCH v2 2/6] add line number and file name info to `config_set` Tanay Abhra
2014-07-25 12:58 ` [PATCH v2 3/6] rewrite git_config() to use the config-set API Tanay Abhra
2014-07-25 13:58   ` Matthieu Moy
2014-07-25 14:07     ` Tanay Abhra
2014-07-25 12:58 ` [PATCH v2 4/6] add a test for semantic errors in config files Tanay Abhra
2014-07-25 12:58 ` [PATCH v2 5/6] config: add `git_die_config()` to the config-set API Tanay Abhra
2014-07-25 14:03   ` Matthieu Moy
2014-07-25 14:12     ` Tanay Abhra
2014-07-25 17:29       ` Junio C Hamano [this message]
2014-07-25 12:58 ` [PATCH v2 6/6] Add tests for `git_config_get_string()` Tanay Abhra

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqqmwbx73fl.fsf@gitster.dls.corp.google.com \
    --to=gitster@pobox$(echo .)com \
    --cc=Matthieu.Moy@grenoble-inp$(echo .)fr \
    --cc=artagnon@gmail$(echo .)com \
    --cc=git@vger$(echo .)kernel.org \
    --cc=tanayabh@gmail$(echo .)com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox