From: Junio C Hamano <gitster@pobox•com>
To: Matthieu Moy <Matthieu.Moy@grenoble-inp•fr>
Cc: Tanay Abhra <tanayabh@gmail•com>,
git@vger•kernel.org, Ramkumar Ramachandra <artagnon@gmail•com>
Subject: Re: [PATCH v7 1/2] add `config_set` API for caching config-like files
Date: Wed, 09 Jul 2014 08:17:22 -0700 [thread overview]
Message-ID: <xmqqmwci7e9p.fsf@gitster.dls.corp.google.com> (raw)
In-Reply-To: <vpqion68viq.fsf@anie.imag.fr> (Matthieu Moy's message of "Wed, 09 Jul 2014 16:19:25 +0200")
Matthieu Moy <Matthieu.Moy@grenoble-inp•fr> writes:
> My opinion on this:
>
> * It's low priority. I think the order of priority should be (high to
> low)
>
> 1) Finish and get the current series into pu (we're almost there, it's
> not time to back off and restart something new).
>
> 2) Work on the other series that uses the new API. We don't need to
> change _all_ the uses, but we do need a few tens of them to
> validate the fact that the new API is nice and convenient to use.
>
> 3) Get new actual features for the user (tidy up config files, give
> error messages based on numbers).
>
> You probably won't finish everything, so just think: if the GSoC ends
> between 1) and 2), how serious is it? if it ends between 2) and 3),
> how serious? If reverse the order, then the risk of having nothing
> finished and mergeable at the end is high. If it happens, the
> community may or may not take over and finish it ...
>
> * Still, making sure that the (file, line) is doable later without too
> much change is good. So, if indeed, moving all code to another file is
> required, then it may make sense to do it now to avoid code move
> later.
Good thinking. As long as the code is prepared, it is a good idea
to start small and bite off only we can chew at once, do things
incrementally.
>> 1. config-hash.c had to be shifted to config.c entirely.
>
> Why? I guess one reason is the use of struct cf (are there others?), but
> moving just
>
> config_hash_callback
> config_hash_add_value
> git_configset_add_file
>
> to config.c should do it. Then, config.c could use config-hash.c.
I am not sure why you guys needed a new file config-hash.c to begin
with, actually. Besides, "hash" in its name is an implementation
detail (what it gives us is a way to grab values for configuration
variables from a config set) which we would rather not want to see.
next prev parent reply other threads:[~2014-07-09 15:17 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-09 10:57 [PATCH v6 0/3] git config cache & special querying api utilizing the cache Tanay Abhra
2014-07-09 10:57 ` [PATCH v7 1/2] add `config_set` API for caching config-like files Tanay Abhra
2014-07-09 12:12 ` Matthieu Moy
2014-07-09 12:39 ` Tanay Abhra
2014-07-09 14:19 ` Matthieu Moy
2014-07-09 15:17 ` Junio C Hamano [this message]
2014-07-09 17:44 ` Junio C Hamano
2014-07-10 9:41 ` Matthieu Moy
2014-07-10 16:46 ` Junio C Hamano
2014-07-09 16:07 ` Tanay Abhra
2014-07-10 11:23 ` Matthieu Moy
2014-07-09 10:57 ` [PATCH v7 2/2] test-config: Add tests for the config_set API Tanay Abhra
2014-07-09 12:13 ` Matthieu Moy
2014-07-09 12:42 ` Tanay Abhra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqmwci7e9p.fsf@gitster.dls.corp.google.com \
--to=gitster@pobox$(echo .)com \
--cc=Matthieu.Moy@grenoble-inp$(echo .)fr \
--cc=artagnon@gmail$(echo .)com \
--cc=git@vger$(echo .)kernel.org \
--cc=tanayabh@gmail$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox