From: Junio C Hamano <gitster@pobox•com>
To: Christian Couder <chriscool@tuxfamily•org>
Cc: git@vger•kernel.org, johan@herland•net, josh@joshtriplett•org,
tr@thomasrast•ch, mhagger@alum•mit.edu, dan.carpenter@oracle•com,
greg@kroah•com, peff@peff•net, sunshine@sunshineco•com,
ramsay@ramsay1•demon.co.uk, jrnieder@gmail•com
Subject: Re: [PATCH v12 11/11] Documentation: add documentation for 'git interpret-trailers'
Date: Sun, 29 Jun 2014 23:40:22 -0700 [thread overview]
Message-ID: <xmqqmwcuzyqx.fsf@gitster.dls.corp.google.com> (raw)
In-Reply-To: <20140629.113731.1129545703421115235.chriscool@tuxfamily.org> (Christian Couder's message of "Sun, 29 Jun 2014 11:37:31 +0200 (CEST)")
Christian Couder <chriscool@tuxfamily•org> writes:
>> While I agree with Michael on the other thread that we should limit
>> the syntax and start with ':' only, if you really want to allow
>> random syntax like "Bug #12345" and "Acked-by= Peff", for which you
>> have demonstrations in the tests in the other patch, the above rule
>> should be updated to also allow prefix matches to possible set of
>> keys defined by the user, so that an existing line that is produced
>> by your tool, e.g. "Acked-by= Peff", can be picked up as matching
>> with some token having a key "Acked-by= ". Otherwise, the input
>> side of your tool is inconsistent with the output side of your own
>> tool, and that will make the flexiblity of the output side useless.
>
> I don't think that the flexibility of the output side would be
> useless.
Flexibility is useful, only if you can control it.
> We already emit stuff like:
>
> (cherry picked from commit f72baf07969242882128aff4c95ec8059e7fd054)
>
> and we don't care about any input side when we do that.
That is something you may want to _fix_, not take as an excuse to
make things worse, no?
next prev parent reply other threads:[~2014-06-30 6:40 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-25 5:32 [PATCH v12 00/11] Add interpret-trailers builtin Christian Couder
2014-05-25 5:32 ` [PATCH v12 01/11] trailer: add data structures and basic functions Christian Couder
2014-05-25 5:32 ` [PATCH v12 02/11] trailer: process trailers from input message and arguments Christian Couder
2014-05-25 5:32 ` [PATCH v12 03/11] trailer: read and process config information Christian Couder
2014-05-25 5:32 ` [PATCH v12 04/11] trailer: process command line trailer arguments Christian Couder
2014-05-25 5:32 ` [PATCH v12 05/11] trailer: parse trailers from file or stdin Christian Couder
2014-05-25 5:32 ` [PATCH v12 06/11] trailer: put all the processing together and print Christian Couder
2014-05-25 5:32 ` [PATCH v12 07/11] trailer: add interpret-trailers command Christian Couder
2014-05-25 5:32 ` [PATCH v12 08/11] trailer: add tests for "git interpret-trailers" Christian Couder
2014-05-28 19:28 ` Junio C Hamano
2014-05-25 5:32 ` [PATCH v12 09/11] trailer: execute command from 'trailer.<name>.command' Christian Couder
2014-05-25 5:32 ` [PATCH v12 10/11] trailer: add tests for commands in config file Christian Couder
2014-05-25 5:32 ` [PATCH v12 11/11] Documentation: add documentation for 'git interpret-trailers' Christian Couder
2014-05-28 19:35 ` Junio C Hamano
2014-06-29 9:37 ` Christian Couder
2014-06-30 6:40 ` Junio C Hamano [this message]
2014-05-28 19:44 ` Junio C Hamano
2014-06-30 11:57 ` Jakub Narębski
2014-07-01 13:34 ` Christian Couder
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqmwcuzyqx.fsf@gitster.dls.corp.google.com \
--to=gitster@pobox$(echo .)com \
--cc=chriscool@tuxfamily$(echo .)org \
--cc=dan.carpenter@oracle$(echo .)com \
--cc=git@vger$(echo .)kernel.org \
--cc=greg@kroah$(echo .)com \
--cc=johan@herland$(echo .)net \
--cc=josh@joshtriplett$(echo .)org \
--cc=jrnieder@gmail$(echo .)com \
--cc=mhagger@alum$(echo .)mit.edu \
--cc=peff@peff$(echo .)net \
--cc=ramsay@ramsay1$(echo .)demon.co.uk \
--cc=sunshine@sunshineco$(echo .)com \
--cc=tr@thomasrast$(echo .)ch \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox