Subject: Re: [PATCH v6 05/11] trace: add infrastructure to augment trace output with additional info

From: Junio C Hamano <[email-masked]>
Date: Fri, 20 Jun 2014 15:33:22 -0700

Karsten Blees <[email-masked]> writes:

> To be able to add a common prefix or suffix to all trace output (e.g.
> a timestamp or file:line of the caller), factor out common setup and
> cleanup tasks of the trace* functions.
>
> Some unit-tests use trace output to verify internal state, and variable
> output such as timestamps and line numbers are not useful there. Disable
> additional trace output if GIT_TRACE_BARE is set.

Hmph, this makes me wonder if we are better off making these
additional trace output optional, i.e. not disabling with
GIT_TRACE_BARE like this, but show the new output only when
explicitly asked for by setting GIT_TRACE_PERF or something.

-- 
-- 
*** Please reply-to-all at all times ***
*** (do not pretend to know who is subscribed and who is not) ***
*** Please avoid top-posting. ***
The msysGit Wiki is here: https://github.com/msysgit/msysgit/wiki - Github accounts are free.

You received this message because you are subscribed to the Google
Groups "msysGit" group.
To post to this group, send email to [email-masked]
To unsubscribe from this group, send email to
[email-masked]
For more options, and view previous threads, visit this group at
http://groups.google.com/group/msysgit?hl=en_US?hl=en

--- 
You received this message because you are subscribed to the Google Groups "msysGit" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [email-masked].
For more options, visit https://groups.google.com/d/optout.