From: Junio C Hamano <gitster@pobox•com>
To: Heiko Voigt <hvoigt@hvoigt•net>
Cc: Stepan Kasal <kasal@ucw•cz>,
GIT Mailing-list <git@vger•kernel.org>,
Johannes Sixt <j6t@kdbg•org>
Subject: Re: [PATCH] Windows: Always normalize paths to Windows-style
Date: Wed, 07 May 2014 13:40:05 -0700 [thread overview]
Message-ID: <xmqqmwet8gre.fsf@gitster.dls.corp.google.com> (raw)
In-Reply-To: <20140507184444.GB4013@sandbox-ub> (Heiko Voigt's message of "Wed, 7 May 2014 20:44:44 +0200")
Heiko Voigt <hvoigt@hvoigt•net> writes:
> On Mon, Apr 28, 2014 at 04:29:31PM +0200, Stepan Kasal wrote:
>> this is another patch that lives in msysGit for a long time.
>> Originally, it had two parts:
>> (Cf https://github.com/msysgit/git/commit/64a8a03 )
>>
>> 1) adding alias pwd='pwd -W' to git-sh-setup.sh
>> This one went upstream, though as a shell function.
>>
>> 2) revert of commit 4dce7d9b by Johannes Sixt <j6t@kdbg•org>
>> This mingw-specific commit was created less than 3 weeks before
>> it was reverted. And it stayed reverted for two years.
>>
>> Could you please either accept this patch, or revert 4dce7d9b ?
>> (Both alternatives are exactly the same.)
>
> Sorry for the late reply. To me reverting (or omitting at the next
> rebasing merge) this patch sound fine, as it seems to be superseeded by
> the upstream change.
>
> As I can see thats already done on master, so it seems to be all good.
Are you guys talking about be39048a (git-sh-setup.sh: Add an pwd()
function for MinGW, 2012-04-17) which has been in since v1.7.11?
The change introduced by 4dce7d9b (submodules: fix ambiguous
absolute paths under Windows, 2012-03-04) still exists, but your
"reverting this patch sound fine" confuses me.
next prev parent reply other threads:[~2014-05-07 20:40 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-28 8:39 [PATCH] Sleep 1 millisecond in poll() to avoid busy wait Stepan Kasal
2014-04-28 9:07 ` Erik Faye-Lund
2014-04-28 11:38 ` Stepan Kasal
2014-04-28 11:42 ` [PATCH] poll/select: prevent busy-waiting Stepan Kasal
2014-04-28 11:44 ` Erik Faye-Lund
2014-04-28 14:29 ` [PATCH] Windows: Always normalize paths to Windows-style Stepan Kasal
2014-04-28 15:26 ` Stepan Kasal
2014-05-07 18:44 ` Heiko Voigt
2014-05-07 20:40 ` Junio C Hamano [this message]
2014-05-08 10:11 ` Stepan Kasal
2014-05-08 20:13 ` Junio C Hamano
2014-05-08 20:36 ` [PATCH] Revert "submodules: fix ambiguous absolute paths under Windows" Stepan Kasal
2014-04-28 15:05 ` [PATCH] poll/select: prevent busy-waiting Johannes Sixt
2014-04-28 15:35 ` [PATCH v2] Sleep 1 millisecond in poll() to avoid busy wait Stepan Kasal
2014-04-28 15:37 ` Erik Faye-Lund
2014-04-28 18:58 ` Junio C Hamano
2014-04-29 3:47 ` Stepan Kasal
2014-04-29 16:51 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqmwet8gre.fsf@gitster.dls.corp.google.com \
--to=gitster@pobox$(echo .)com \
--cc=git@vger$(echo .)kernel.org \
--cc=hvoigt@hvoigt$(echo .)net \
--cc=j6t@kdbg$(echo .)org \
--cc=kasal@ucw$(echo .)cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox