public inbox for git@vger.kernel.org 
 help / color / mirror / Atom feed

From: Junio C Hamano <gitster@pobox•com>
To: Paul Mackerras <paulus@samba•org>
Cc: git@vger•kernel.org, Ilya Bobyr <ilya.bobyr@gmail•com>
Subject: [PATCH] gitk: replace SHA1 entry field on keyboard paste
Date: Tue, 04 Mar 2014 10:15:07 -0800	[thread overview]
Message-ID: <xmqqmwh5ltjo.fsf@gitster.dls.corp.google.com> (raw)
In-Reply-To: <1393570297-6012-1-git-send-email-ilya.bobyr@gmail.com> (Ilya Bobyr's message of "Thu, 27 Feb 2014 22:51:37 -0800")

From: Ilya Bobyr <ilya.bobyr@gmail•com>
Date: Thu, 27 Feb 2014 22:51:37 -0800

We already replace old SHA with the clipboard content for the mouse
paste event.  It seems reasonable to do the same when pasting from
keyboard.

Signed-off-by: Ilya Bobyr <ilya.bobyr@gmail•com>
---

 * Paul?  I do not use <<Paste>> on my keyboard, so I am not in the
   position to say that this patch is correct (or not).  I am just
   forwarding it in case you think gitk users will find it useful.

   The original patch was done against my tree, so I hand tweaked it
   to apply to your tree.
   
   Thanks.

 gitk |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/gitk b/gitk
index 90764e8..2f58bcf 100755
--- a/gitk
+++ b/gitk
@@ -2585,6 +2585,7 @@ proc makewindow {} {
     bind $fstring <Key-Return> {dofind 1 1}
     bind $sha1entry <Key-Return> {gotocommit; break}
     bind $sha1entry <<PasteSelection>> clearsha1
+    bind $sha1entry <<Paste>> clearsha1
     bind $cflist <1> {sel_flist %W %x %y; break}
     bind $cflist <B1-Motion> {sel_flist %W %x %y; break}
     bind $cflist <ButtonRelease-1> {treeclick %W %x %y}

next prev parent reply	other threads:[~2014-03-04 18:15 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-02-28  6:51 [PATCH] gitk: replace SHA1 entry field on keyboard paste Ilya Bobyr
2014-03-04 18:15 ` Junio C Hamano [this message]
2014-03-05  8:48   ` Ilya Bobyr
     [not found]     ` <1395305931-5248-1-git-send-email-ilya.bobyr@gmail.com>
2014-06-15  4:55       ` Paul Mackerras
  -- strict thread matches above, loose matches on Subject: below --
2014-02-27  9:56 Ilya Bobyr

find likely ancestor, descendant, or conflicting patches for this message:
( dfblob:90764e8 dfblob:2f58bcf )
 OR (
bs:"[PATCH] gitk: replace SHA1 entry field on keyboard paste" )
	(help)

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqqmwh5ltjo.fsf@gitster.dls.corp.google.com \
    --to=gitster@pobox$(echo .)com \
    --cc=git@vger$(echo .)kernel.org \
    --cc=ilya.bobyr@gmail$(echo .)com \
    --cc=paulus@samba$(echo .)org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox