public inbox for git@vger.kernel.org 
 help / color / mirror / Atom feed

From: Junio C Hamano <gitster@pobox•com>
To: szager@chromium•org
Cc: git@vger•kernel.org
Subject: Re: [PATCH v2] Make the global packed_git variable static to sha1_file.c.
Date: Wed, 12 Feb 2014 12:28:04 -0800	[thread overview]
Message-ID: <xmqqmwhwm5yj.fsf@gitster.dls.corp.google.com> (raw)
In-Reply-To: <52fbc2d6.7kJdh2GOdWTzNcPK%szager@chromium.org> (szager@chromium.org's message of "Wed, 12 Feb 2014 10:52:06 -0800")

I'll locally fix up these style issues before commenting on the patch.

Thanks.

ERROR: space required after that ',' (ctx:VxV)
#78: FILE: builtin/count-objects.c:111:
+	struct pack_data pd = {0,0,0};
 	                        ^

ERROR: space required after that ',' (ctx:VxV)
#78: FILE: builtin/count-objects.c:111:
+	struct pack_data pd = {0,0,0};
 	                          ^

ERROR: space required after that ',' (ctx:VxV)
#171: FILE: builtin/fsck.c:683:
+		struct verify_packs_data vpd = {0,0,0};
 		                                 ^

ERROR: space required after that ',' (ctx:VxV)
#171: FILE: builtin/fsck.c:683:
+		struct verify_packs_data vpd = {0,0,0};
 		                                   ^

ERROR: space required after that ',' (ctx:VxV)
#541: FILE: builtin/pack-redundant.c:591:
+	struct add_pack_data apd = {filename,0,NULL};
 	                                    ^

ERROR: space required after that ',' (ctx:VxV)
#541: FILE: builtin/pack-redundant.c:591:
+	struct add_pack_data apd = {filename,0,NULL};
 	                                      ^

ERROR: space required after that ',' (ctx:VxV)
#565: FILE: builtin/pack-redundant.c:604:
+	struct add_pack_data apd = {NULL,0,NULL};
 	                                ^

ERROR: space required after that ',' (ctx:VxV)
#565: FILE: builtin/pack-redundant.c:604:
+	struct add_pack_data apd = {NULL,0,NULL};
 	                                  ^

ERROR: space prohibited after that '-' (ctx:WxW)
#726: FILE: pack-revindex.c:47:
+	num = - 1 - num;
 	      ^

ERROR: space required after that ',' (ctx:VxV)
#901: FILE: sha1_name.c:195:
+	struct disambiguate_data d = {len,bin_pfx,ds};
 	                                 ^

ERROR: space required after that ',' (ctx:VxV)
#901: FILE: sha1_name.c:195:
+	struct disambiguate_data d = {len,bin_pfx,ds};
 	                                         ^

total: 11 errors, 0 warnings, 781 lines checked

next prev parent reply	other threads:[~2014-02-12 20:28 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-02-12 18:52 [PATCH v2] Make the global packed_git variable static to sha1_file.c szager
2014-02-12 20:28 ` Junio C Hamano [this message]
2014-02-12 21:19 ` Junio C Hamano
2014-02-13 23:15   ` Stefan Zager

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqqmwhwm5yj.fsf@gitster.dls.corp.google.com \
    --to=gitster@pobox$(echo .)com \
    --cc=git@vger$(echo .)kernel.org \
    --cc=szager@chromium$(echo .)org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox