Subject: Re: [PATCH v5 04/14] trailer: process command line trailer arguments

From: Junio C Hamano <[email-masked]>
Date: Thu, 06 Feb 2014 16:08:24 -0800

Christian Couder <[email-masked]> writes:

> This patch parses the trailer command line arguments
> and put the result into an arg_tok doubly linked
> list.

No the patch doesn't parse anything ;-).

"Parse the command line arguments and ...".

> +static void parse_trailer(struct strbuf *tok, struct strbuf *val, const char *trailer)
> +{
> +	const char *end = strchr(trailer, '=');
> +	if (!end)
> +		end = strchr(trailer, ':');

How would you explain the behaviour of the above code for this
input?

	frotz: nitfol=xyzzy

Perhaps strcspn()?