From: Junio C Hamano <gitster@pobox•com>
To: Sebastian Schuberth <sschuberth@gmail•com>
Cc: Michael Haggerty <mhagger@alum•mit.edu>,
Git Mailing List <git@vger•kernel.org>,
Johannes Schindelin <johannes.schindelin@gmx•de>
Subject: Re: [PATCH v2] safe_create_leading_directories(): on Windows, \ can separate path components
Date: Tue, 21 Jan 2014 11:35:27 -0800 [thread overview]
Message-ID: <xmqqmwipuo00.fsf@gitster.dls.corp.google.com> (raw)
In-Reply-To: <CAHGBnuMmutYqwZNw+VoZi=R_LaS_fowZrqaU2+JMYN53q6XQ2Q@mail.gmail.com> (Sebastian Schuberth's message of "Sun, 19 Jan 2014 21:26:38 +0100")
Sebastian Schuberth <sschuberth@gmail•com> writes:
> On Sun, Jan 19, 2014 at 12:40 AM, Michael Haggerty <mhagger@alum•mit.edu> wrote:
>
>> This patch applies on top of v3 of mh/safe-create-leading-directories.
>>
>> The only logical change from Sebastian's patch is that this version
>> restores the original slash character rather than always restoring it
>> to '/' (as suggested by Junio).
>
> Thanks Michael. This is very similar to Junio's current merge conflict
> resultion in pu between your original series and my patch (c2fec83). I
> like this patch of yours slightly better, however, as it uses a
> "while" instead of a "for" loop and the more conclusive
> "slash_character" than the "was_slash" variable name.
Yeah, I agree this patch that uses more descriptive names is a much
more desirable end-result than the tentative merge in 'pu'.
prev parent reply other threads:[~2014-01-21 19:35 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-18 23:40 [PATCH v2] safe_create_leading_directories(): on Windows, \ can separate path components Michael Haggerty
2014-01-19 20:26 ` Sebastian Schuberth
2014-01-21 19:35 ` Junio C Hamano [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqmwipuo00.fsf@gitster.dls.corp.google.com \
--to=gitster@pobox$(echo .)com \
--cc=git@vger$(echo .)kernel.org \
--cc=johannes.schindelin@gmx$(echo .)de \
--cc=mhagger@alum$(echo .)mit.edu \
--cc=sschuberth@gmail$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox