public inbox for git@vger.kernel.org 
 help / color / mirror / Atom feed

From: Junio C Hamano <gitster@pobox•com>
To: Jeff King <peff@peff•net>
Cc: Duy Nguyen <pclouds@gmail•com>, Git Mailing List <git@vger•kernel.org>
Subject: Re: [PATCH v2 0/3] rev-parse and "--"
Date: Mon, 09 Dec 2013 11:05:09 -0800	[thread overview]
Message-ID: <xmqqmwk9zvyy.fsf@gitster.dls.corp.google.com> (raw)
In-Reply-To: <20131206220520.GA30652@sigill.intra.peff.net> (Jeff King's message of "Fri, 6 Dec 2013 17:05:20 -0500")

Jeff King <peff@peff•net> writes:

> Is it better for "rev-parse" to be more careful, and to behave more like
> the rest of git? Or is better to be historically compatible?
>
> One thing to note is that "git rev-parse HEAD" is slightly broken there
> already. Because "git rev-parse $some_branch" may do very different
> things than what the caller expects if $some_branch does not exist (but
> there is a file with the same name). So maybe we are doing a favor by
> calling out the problem; if they want a rev, they should be using
> "--verify" (or "--").

I tend to agree with the reasoning in the last sentence. Let's cook
it for a while and see what happens.

Thanks.

next prev parent reply	other threads:[~2013-12-09 19:05 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-12-05 10:07 [BUG] redundant error message Duy Nguyen
2013-12-05 19:15 ` Jeff King
2013-12-05 20:00   ` Junio C Hamano
2013-12-05 20:03     ` Jeff King
2013-12-05 20:15       ` Junio C Hamano
2013-12-05 21:00         ` Jeff King
2013-12-05 21:28           ` Jeff King
2013-12-05 21:44             ` Junio C Hamano
2013-12-06 21:12               ` [PATCH 0/2] rev-parse and "--" Jeff King
2013-12-06 21:13                 ` [PATCH 1/2] rev-parse: correctly diagnose revision errors before "--" Jeff King
2013-12-06 21:15                 ` [PATCH 2/2] rev-parse: diagnose ambiguous revision/filename arguments Jeff King
2013-12-06 22:05                   ` [PATCH v2 0/3] rev-parse and "--" Jeff King
2013-12-06 22:05                     ` [PATCH v2 1/3] rev-parse: correctly diagnose revision errors before "--" Jeff King
2013-12-06 23:34                       ` Jonathan Nieder
2013-12-06 22:07                     ` [PATCH v2 2/3] rev-parse: be more careful with munging arguments Jeff King
2013-12-07  0:04                       ` Jonathan Nieder
2013-12-09 21:33                       ` Eric Sunshine
2013-12-06 22:08                     ` [PATCH v2 3/3] rev-parse: diagnose ambiguous revision/filename arguments Jeff King
2013-12-06 23:25                     ` [PATCH v2 0/3] rev-parse and "--" Jonathan Nieder
2013-12-06 23:30                       ` Jeff King
2013-12-09 19:05                     ` Junio C Hamano [this message]
2013-12-09 19:12                       ` Jonathan Nieder
2013-12-09 19:23                         ` Jonathan Nieder
2013-12-09 20:48                         ` Junio C Hamano
2013-12-09 20:56                           ` Jonathan Nieder
2013-12-09 21:10                             ` Junio C Hamano
2013-12-06  1:15             ` [BUG] redundant error message Duy Nguyen
2013-12-06 22:13               ` Jeff King

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqqmwk9zvyy.fsf@gitster.dls.corp.google.com \
    --to=gitster@pobox$(echo .)com \
    --cc=git@vger$(echo .)kernel.org \
    --cc=pclouds@gmail$(echo .)com \
    --cc=peff@peff$(echo .)net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox