From: Junio C Hamano <gitster@pobox•com>
To: Andreas Ericsson <ae@op5•se>
Cc: Jim Meyering <jim@meyering•net>, Marcus Karlsson <mk@acc•umu.se>,
git list <git@vger•kernel.org>
Subject: Re: [PATCH] diff: avoid stack-buffer-read-overrun for very long name
Date: Fri, 27 Apr 2012 08:07:55 -0700 [thread overview]
Message-ID: <xmqqmx5x9pro.fsf@junio.mtv.corp.google.com> (raw)
In-Reply-To: <4F9A972E.7050401@op5.se> (Andreas Ericsson's message of "Fri, 27 Apr 2012 14:55:10 +0200")
Andreas Ericsson <ae@op5•se> writes:
>> I am not good at names, but strbuf_terminate_with(&buffer2, '/')
>> perhaps?
>>
> "terminate" sounds pretty final though.
Yeah, but that function is adding a record terminator to the buffer, so...
> How about strbuf_ensure_suffixch()?
> It embeds the 'ch', marking it as a char argument...
Perhaps.
prev parent reply other threads:[~2012-04-27 15:08 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-16 15:20 [PATCH] diff: avoid stack-buffer-read-overrun for very long name Jim Meyering
2012-04-16 22:27 ` Marcus Karlsson
2012-04-24 16:09 ` Jim Meyering
2012-04-25 19:37 ` Junio C Hamano
2012-04-26 15:52 ` Jim Meyering
2012-04-26 16:13 ` Junio C Hamano
2012-04-26 16:21 ` Bert Wesarg
2012-04-26 16:26 ` Jim Meyering
2012-04-26 16:53 ` Bert Wesarg
2012-04-26 17:26 ` Jim Meyering
2012-04-26 16:22 ` Jim Meyering
2012-04-27 12:55 ` Andreas Ericsson
2012-04-27 15:07 ` Junio C Hamano [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqmx5x9pro.fsf@junio.mtv.corp.google.com \
--to=gitster@pobox$(echo .)com \
--cc=ae@op5$(echo .)se \
--cc=git@vger$(echo .)kernel.org \
--cc=jim@meyering$(echo .)net \
--cc=mk@acc$(echo .)umu.se \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox