Subject: Re: [GSoC][PATCH v5 0/7] t: port reftable/stack_test.c to the unit testing framework

From: Junio C Hamano <[email-masked]>
Date: Fri, 06 Sep 2024 09:38:01 -0700

Chandra Pratap <[email-masked]> writes:

> Changes in v5:
> - Edit the commit messages in patches 3 and 4 to reflect the changes
>   and the motivation behind those changes better.
> - Add newlines after variable declarations in patch 6.
> - Introduce patch 7 which removes leftover cruft from the previous
>   reftable testing scheme.

Hmph, the end-result looks good to me, but the structure of the
series is a bit curious.  I didn't expect there will be a separate
step for removal.  Shouldn't these "leftover cruft" be removed *in*
the same step that they become cruft (which I am assuming is when
reftable/stack_test.c and all references to it gets removed in an
early part of the series)?

Other than that, looking good.

Thanks.