Subject: Re: [PATCH v4 6/6] tests: don't lose misc "git" exit codes

From: Junio C Hamano <[email-masked]>
Date: Wed, 28 Dec 2022 08:17:28 +0900

Phillip Wood <[email-masked]> writes:

>> -	test -z "$(git diff file)"
>> ...
>> +	git diff file >out &&
>> +	test_must_be_empty out
>
> "git diff --exit-code file" would suffice here, we don't need to
> redirect the output and check that it is empty.

Yes, but the test is trying to be faithful to not just the intent
but also the implementation of the original, I think.