From: Junio C Hamano <gitster@pobox•com>
To: Kristoffer Haugsbakk <kristoffer.haugsbakk@gmail•com>
Cc: Philip Oakley <philipoakley@iee•org>, git@vger•kernel.org
Subject: Re: [PATCH 1/4] doc: add articles (grammar)
Date: Tue, 13 Dec 2016 10:11:36 -0800 [thread overview]
Message-ID: <xmqqoa0f4s2v.fsf@gitster.mtv.corp.google.com> (raw)
In-Reply-To: <8737hsj7wp.fsf@gmail.com> (Kristoffer Haugsbakk's message of "Tue, 13 Dec 2016 14:05:58 +0100")
Kristoffer Haugsbakk <kristoffer.haugsbakk@gmail•com> writes:
> Thank you for reviewing this series, Philip.
>
> Philip Oakley writes:
>
>> This looks good to me.
>
> I'll add this header:
>
> Acked-by: Philip Oakley <philipoakley@iee•org>
>
> To the commit message of this patch in the next review round (version 2
> of the patch series).
>
> Let me know if I should add another header, or do something different
> than this.
I was planning to merge all four from you as-is to 'next' today,
though. Should I wait?
next prev parent reply other threads:[~2016-12-13 18:11 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-09 15:51 [PATCH 0/4] doc: fixes to gitcore-tutorial.txt Kristoffer Haugsbakk
2016-12-09 15:51 ` [PATCH 1/4] doc: add articles (grammar) Kristoffer Haugsbakk
2016-12-10 20:28 ` Philip Oakley
2016-12-13 13:05 ` Kristoffer Haugsbakk
2016-12-13 18:11 ` Junio C Hamano [this message]
2016-12-13 21:34 ` Kristoffer Haugsbakk
2016-12-09 15:51 ` [PATCH 2/4] doc: add verb in front of command to run Kristoffer Haugsbakk
2016-12-10 20:48 ` Philip Oakley
2016-12-09 15:51 ` [PATCH 3/4] doc: make the intent of sentence clearer Kristoffer Haugsbakk
2016-12-10 20:52 ` Philip Oakley
2016-12-13 13:23 ` Kristoffer Haugsbakk
2016-12-09 15:51 ` [PATCH 4/4] doc: omit needless "for" Kristoffer Haugsbakk
2016-12-11 13:04 ` Philip Oakley
2016-12-11 14:08 ` Philip Oakley
2016-12-09 23:13 ` [PATCH 0/4] doc: fixes to gitcore-tutorial.txt Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqoa0f4s2v.fsf@gitster.mtv.corp.google.com \
--to=gitster@pobox$(echo .)com \
--cc=git@vger$(echo .)kernel.org \
--cc=kristoffer.haugsbakk@gmail$(echo .)com \
--cc=philipoakley@iee$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox