From: Junio C Hamano <gitster@pobox•com>
To: git@vger•kernel.org
Cc: peff@peff•net, dborowitz@google•com, stanislav@assembla•com
Subject: Re: [PATCH v4] git-send-pack: fix --all option when used with directory
Date: Thu, 31 Mar 2016 15:02:43 -0700 [thread overview]
Message-ID: <xmqqoa9ul30c.fsf@gitster.mtv.corp.google.com> (raw)
In-Reply-To: <xmqq1t6qmlxk.fsf@gitster.mtv.corp.google.com> (Junio C. Hamano's message of "Thu, 31 Mar 2016 13:28:39 -0700")
Junio C Hamano <gitster@pobox•com> writes:
> stanislav@assembla•com writes:
>
>> From: Stanislav Kolotinskiy <stanislav@assembla•com>
>>
>> When using git send-pack with --all option
>> and a target repository specification ([<host>:]<directory>),
>> usage message is being displayed instead of performing
>> the actual transmission.
>>
>> The reason for this issue is that destination and refspecs are being set
>> in the same conditional and are populated from argv. When a target
>> repository is passed, refspecs is being populated as well with its value.
>> This makes the check for refspecs not being NULL to always return true,
>> which, in conjunction with the check for --all or --mirror options,
>> is always true as well and returns usage message instead of proceeding.
>>
>> This ensures that send-pack will stop execution only when --all
>> or --mirror switch is used in conjunction with any refspecs passed.
>>
>> Signed-off-by: Stanislav Kolotinskiy <stanislav@assembla•com>
>> ---
>
> Thanks, will queue.
By the way, for some reason it was unusually painful to find the
exact breakage by bisecting between maint-2.4 and maint-2.6. It
somehow ended up on fingering random places like v2.6.0 itself.
The true culprit is 068c77a5 (builtin/send-pack.c: use parse_options
API, 2015-08-19). I didn't dug deep enough to tell if we recently
broke "git bisect" or if there are something wrong in the shape of
my history.
next prev parent reply other threads:[~2016-03-31 22:02 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-31 13:55 [PATCH v4] git-send-pack: fix --all option when used with directory stanislav
2016-03-31 20:28 ` Junio C Hamano
2016-03-31 22:02 ` Junio C Hamano [this message]
2016-03-31 22:55 ` Eric Sunshine
2016-03-31 23:26 ` Jeff King
2016-04-01 10:44 ` Stanislav Kolotinskiy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqoa9ul30c.fsf@gitster.mtv.corp.google.com \
--to=gitster@pobox$(echo .)com \
--cc=dborowitz@google$(echo .)com \
--cc=git@vger$(echo .)kernel.org \
--cc=peff@peff$(echo .)net \
--cc=stanislav@assembla$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox