From: Junio C Hamano <gitster@pobox•com>
To: Antoine Delaite <antoine.delaite@ensimag•grenoble-inp.fr>
Cc: git@vger•kernel.org, remi.lespinet@ensimag•grenoble-inp.fr,
louis--alexandre.stuber@ensimag•grenoble-inp.fr,
remi.galan-alfonso@ensimag•grenoble-inp.fr,
guillaume.pages@ensimag•grenoble-inp.fr,
Matthieu.Moy@grenoble-inp•fr, chriscool@tuxfamily•org,
thomasxnguy@gmail•com, valentinduperray@gmail•com
Subject: Re: [PATCH v2 4/7] bisect: add the terms old/new
Date: Wed, 10 Jun 2015 14:03:29 -0700 [thread overview]
Message-ID: <xmqqoakni8da.fsf@gitster.dls.corp.google.com> (raw)
In-Reply-To: <1433953472-32572-4-git-send-email-antoine.delaite@ensimag.grenoble-inp.fr> (Antoine Delaite's message of "Wed, 10 Jun 2015 18:24:29 +0200")
Antoine Delaite <antoine.delaite@ensimag•grenoble-inp.fr> writes:
> Related discussions:
>
> - http://thread.gmane.org/gmane.comp.version-control.git/86063
> introduced bisect fix unfixed to find fix.
> - http://thread.gmane.org/gmane.comp.version-control.git/182398
> discussion around bisect yes/no or old/new.
> - http://thread.gmane.org/gmane.comp.version-control.git/199758
> last discussion and reviews
Hmph, recent reviews and discussions we had here do not count?
I do agree with Matthieu's review on the last round, which is still
not quite addressed in this round. The current code only supports
good/bad and this series merely adds another hardcoded pair old/new,
which is disappointing, given that this is a very good opportunity
to place an infrastructure to allow other pairs like unfixed/fixed
building on top of the most generic old/new.
next prev parent reply other threads:[~2015-06-10 21:03 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-10 16:24 [PATCH v2 1/7] bisect : correction of typo Antoine Delaite
2015-06-10 16:24 ` [PATCH v2 2/7] bisect: replace hardcoded "bad|good" by variables Antoine Delaite
2015-06-11 15:27 ` Matthieu Moy
2015-06-22 12:42 ` Antoine Delaite
2015-06-22 13:47 ` Matthieu Moy
2015-06-10 16:24 ` [PATCH v2 3/7] bisect: simplify the addition of new bisect terms Antoine Delaite
2015-06-10 16:24 ` [PATCH v2 4/7] bisect: add the terms old/new Antoine Delaite
2015-06-10 21:03 ` Junio C Hamano [this message]
2015-06-14 11:51 ` Louis-Alexandre Stuber
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqoakni8da.fsf@gitster.dls.corp.google.com \
--to=gitster@pobox$(echo .)com \
--cc=Matthieu.Moy@grenoble-inp$(echo .)fr \
--cc=antoine.delaite@ensimag$(echo .)grenoble-inp.fr \
--cc=chriscool@tuxfamily$(echo .)org \
--cc=git@vger$(echo .)kernel.org \
--cc=guillaume.pages@ensimag$(echo .)grenoble-inp.fr \
--cc=louis--alexandre.stuber@ensimag$(echo .)grenoble-inp.fr \
--cc=remi.galan-alfonso@ensimag$(echo .)grenoble-inp.fr \
--cc=remi.lespinet@ensimag$(echo .)grenoble-inp.fr \
--cc=thomasxnguy@gmail$(echo .)com \
--cc=valentinduperray@gmail$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox