From: Junio C Hamano <gitster@pobox•com>
To: Remi Galan Alfonso <remi.galan-alfonso@ensimag•grenoble-inp.fr>
Cc: Matthieu Moy <Matthieu.Moy@grenoble-inp•fr>,
Git List <git@vger•kernel.org>,
Remi Lespinet <remi.lespinet@ensimag•grenoble-inp.fr>,
Guillaume Pages <guillaume.pages@ensimag•grenoble-inp.fr>,
Louis-Alexandre Stuber
<louis--alexandre.stuber@ensimag•grenoble-inp.fr>,
Antoine Delaite <antoine.delaite@ensimag•grenoble-inp.fr>,
Eric Sunshine <sunshine@sunshineco•com>
Subject: Re: [PATCH/RFCv3 2/2] git rebase -i: warn about removed commits
Date: Tue, 02 Jun 2015 11:22:19 -0700 [thread overview]
Message-ID: <xmqqoaky2co4.fsf@gitster.dls.corp.google.com> (raw)
In-Reply-To: <133653833.39653.1433262736640.JavaMail.zimbra@ensimag.grenoble-inp.fr> (Remi Galan Alfonso's message of "Tue, 2 Jun 2015 18:32:16 +0200 (CEST)")
Remi Galan Alfonso <remi.galan-alfonso@ensimag•grenoble-inp.fr>
writes:
> In this case it is not true, because of the infile and outfile being
> identical. However sort does have a -o (-output) that I missed that
> allows avoiding using echo or writing in another file; I'm correcting
> with this.
Even though it is in POSIX, some implementation may lack it, so our
code tend to avoid "sort -o". "echo $(sort)" is also ugly and
inefficient. The obvious and old-fashioned would be sufficient here:
sort -u "$todo".oldsha1 >"$todo".oldsha1+ &&
mv "$todo".oldsha1+ "$todo".oldsha1
next prev parent reply other threads:[~2015-06-02 18:22 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-02 13:36 [PATCH/RFCv3 1/2] git-rebase -i: add command "drop" to remove a commit Galan Rémi
2015-06-02 13:36 ` [PATCH/RFCv3 2/2] git rebase -i: warn about removed commits Galan Rémi
2015-06-02 14:56 ` Matthieu Moy
2015-06-02 16:32 ` Remi Galan Alfonso
2015-06-02 18:22 ` Junio C Hamano [this message]
2015-06-03 6:42 ` Matthieu Moy
2015-06-03 7:33 ` Remi Galan Alfonso
2015-06-03 8:25 ` Remi Galan Alfonso
2015-06-02 14:17 ` [PATCH/RFCv3 1/2] git-rebase -i: add command "drop" to remove a commit Matthieu Moy
2015-06-02 14:32 ` Remi Galan Alfonso
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqoaky2co4.fsf@gitster.dls.corp.google.com \
--to=gitster@pobox$(echo .)com \
--cc=Matthieu.Moy@grenoble-inp$(echo .)fr \
--cc=antoine.delaite@ensimag$(echo .)grenoble-inp.fr \
--cc=git@vger$(echo .)kernel.org \
--cc=guillaume.pages@ensimag$(echo .)grenoble-inp.fr \
--cc=louis--alexandre.stuber@ensimag$(echo .)grenoble-inp.fr \
--cc=remi.galan-alfonso@ensimag$(echo .)grenoble-inp.fr \
--cc=remi.lespinet@ensimag$(echo .)grenoble-inp.fr \
--cc=sunshine@sunshineco$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox