From: Junio C Hamano <gitster@pobox•com>
To: Johannes Schindelin <johannes.schindelin@gmx•de>
Cc: Paul Tan <pyokagan@gmail•com>,
git@vger•kernel.org, Stefan Beller <sbeller@google•com>,
Jeff King <peff@peff•net>
Subject: Re: [PATCH v4 2/8] t5520: test no merge candidates cases
Date: Mon, 18 May 2015 10:46:50 -0700 [thread overview]
Message-ID: <xmqqoalhdbhx.fsf@gitster.dls.corp.google.com> (raw)
In-Reply-To: <e89b333476cbb1e546371a07b357cd42@www.dscho.org> (Johannes Schindelin's message of "Mon, 18 May 2015 17:08:38 +0200")
Johannes Schindelin <johannes.schindelin@gmx•de> writes:
>> +test_expect_success 'fail if wildcard spec does not match any refs' '
>> + git checkout -b test copy^ &&
>> + test_when_finished "git checkout -f copy && git branch -D test" &&
>
> When I read this line, I immediately asked myself whether the
> branch would be deleted even if the test case failed. I then
> tested this theory by editing the first test case ("setup") like
> this:
> ...
> and indeed, the file "file" was gone, even if the test case
> failed. I therefore believe that this "test_when_finished" cleanup
> might make debugging substantially harder. Maybe we can drop these
> lines from this patch?
The test framework is aware of the fact that it needs to help the
people who are debugging the scripts. The support is limited to the
case in which you run it under the -i option, i.e.
$ cd t
$ sh ./t5520-pull.sh -i -v
will refrain from running test_when_finished scripts when the test
piece fails. Even though this is only limited to -i, I found it
often sufficient for debugging.
next prev parent reply other threads:[~2015-05-18 17:46 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-18 13:32 [PATCH v4 0/8] Improve git-pull test coverage Paul Tan
2015-05-18 13:32 ` [PATCH v4 1/8] t5520: prevent field splitting in content comparisons Paul Tan
2015-05-18 18:07 ` Junio C Hamano
2015-05-18 13:32 ` [PATCH v4 2/8] t5520: test no merge candidates cases Paul Tan
2015-05-18 15:08 ` Johannes Schindelin
2015-05-18 17:46 ` Junio C Hamano [this message]
2015-05-18 18:55 ` debugging git tests, was: " Jeff King
2015-05-18 19:35 ` Junio C Hamano
2015-05-19 13:29 ` Johannes Schindelin
2015-06-05 10:44 ` Jeff King
2015-05-18 13:32 ` [PATCH v4 3/8] t5520: test for failure if index has unresolved entries Paul Tan
2015-05-18 15:13 ` Johannes Schindelin
2015-05-21 8:15 ` Paul Tan
2015-05-18 13:32 ` [PATCH v4 4/8] t5520: test work tree fast-forward when fetch updates head Paul Tan
2015-05-18 15:22 ` Johannes Schindelin
2015-05-18 13:32 ` [PATCH v4 5/8] t5520: test --rebase with multiple branches Paul Tan
2015-05-18 13:32 ` [PATCH v4 6/8] t5520: test --rebase failure on unborn branch with index Paul Tan
2015-05-18 18:00 ` Stefan Beller
2015-05-21 8:51 ` Paul Tan
2015-05-18 13:32 ` [PATCH v4 7/8] t5521: test --dry-run does not make any changes Paul Tan
2015-05-18 13:32 ` [PATCH v4 8/8] t5520: check reflog action in fast-forward merge Paul Tan
2015-05-18 15:20 ` Johannes Schindelin
2015-05-21 8:07 ` Paul Tan
2015-05-21 17:29 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqoalhdbhx.fsf@gitster.dls.corp.google.com \
--to=gitster@pobox$(echo .)com \
--cc=git@vger$(echo .)kernel.org \
--cc=johannes.schindelin@gmx$(echo .)de \
--cc=peff@peff$(echo .)net \
--cc=pyokagan@gmail$(echo .)com \
--cc=sbeller@google$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox