From: Junio C Hamano <gitster@pobox•com>
To: karthik nayak <karthik.188@gmail•com>
Cc: git@vger•kernel.org
Subject: Re: [PATCH v2 2/3] sha1_file: implement changes for "cat-file --literally -t"
Date: Wed, 04 Mar 2015 22:25:10 -0800 [thread overview]
Message-ID: <xmqqoao83qrd.fsf@gitster.dls.corp.google.com> (raw)
In-Reply-To: <54F7B0CE.4070006@gmail.com> (karthik nayak's message of "Thu, 05 Mar 2015 06:56:38 +0530")
karthik nayak <karthik.188@gmail•com> writes:
>> Looks suspiciously familiar...
> Yes, you suggested it.
> It has a similar structure to unpack_sha1_header().
> Anything wrong with it?
I don't know if there is something wrong with the code, or not, but
it wasn't mentioned in the log message at all that it is not your
code, and I was mostly reacting to that.
It is fairly common around here to take somebody else's code and run
with it, but people say things like "This is based on suggestion
from X", "This function was stolen from Y", etc. and then conclude
with "but I adjusted it to match the caller I wrote, so bugs are
mine." when they do so.
next prev parent reply other threads:[~2015-03-05 6:25 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-03 10:10 [PATCH v2 0/3] cat-file: add "--literally" option karthik nayak
2015-03-03 10:11 ` [PATCH v2 1/3] cache: modify for "cat-file --literally -t" Karthik Nayak
2015-03-03 10:12 ` [PATCH v2 2/3] sha1_file: implement changes " Karthik Nayak
2015-03-04 20:58 ` Junio C Hamano
2015-03-05 1:26 ` karthik nayak
2015-03-05 6:25 ` Junio C Hamano [this message]
2015-03-03 10:13 ` [PATCH v2 3/3] cat-file: add "--literally" option Karthik Nayak
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqoao83qrd.fsf@gitster.dls.corp.google.com \
--to=gitster@pobox$(echo .)com \
--cc=git@vger$(echo .)kernel.org \
--cc=karthik.188@gmail$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox