From: Junio C Hamano <gitster@pobox•com>
To: Alexander Kuleshov <kuleshovmail@gmail•com>
Cc: git@vger•kernel.org
Subject: Re: [PATCH] cat-file: add short option '-c' for 'cat-file --textconv'
Date: Fri, 09 Jan 2015 14:48:10 -0800 [thread overview]
Message-ID: <xmqqoaq7bmfp.fsf@gitster.dls.corp.google.com> (raw)
In-Reply-To: <1420793279-27853-1-git-send-email-kuleshovmail@gmail.com> (Alexander Kuleshov's message of "Fri, 9 Jan 2015 14:47:59 +0600")
Alexander Kuleshov <kuleshovmail@gmail•com> writes:
> Signed-off-by: Alexander Kuleshov <kuleshovmail@gmail•com>
> ---
> Documentation/git-cat-file.txt | 5 +++--
> builtin/cat-file.c | 4 ++--
> t/t8007-cat-file-textconv.sh | 10 ++++++++++
> 3 files changed, 15 insertions(+), 4 deletions(-)
>
> diff --git a/Documentation/git-cat-file.txt b/Documentation/git-cat-file.txt
> index f6a16f4..b346a5d 100644
> --- a/Documentation/git-cat-file.txt
> +++ b/Documentation/git-cat-file.txt
> @@ -9,14 +9,14 @@ git-cat-file - Provide content or type and size information for repository objec
> SYNOPSIS
> --------
> [verse]
> -'git cat-file' (-t | -s | -e | -p | <type> | --textconv ) <object>
> +'git cat-file' (-t | -s | -e | -p | <type> | (-c | --textconv) ) <object>
Do we use "-c" for a shorthand for "--textconv" anywhere else?
Is there any other command that has "--textconv" where "-c" does not
mean "--textconv"? Or worse yet, where "-c" already means something
completely different from "--textconv"?
Unlike end-user facing Porcelain commands, plumbing commands are
primarily meant to be used in scripts, and I am not sure how much
benefit we are getting by introducing new short options to them.
Ancient plumbing commands do have many single-letter options but
they were added back when more modern set of end-user facing
Porcelain commands did not exist.
prev parent reply other threads:[~2015-01-09 22:48 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-09 8:47 [PATCH] cat-file: add short option '-c' for 'cat-file --textconv' Alexander Kuleshov
2015-01-09 22:48 ` Junio C Hamano [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqoaq7bmfp.fsf@gitster.dls.corp.google.com \
--to=gitster@pobox$(echo .)com \
--cc=git@vger$(echo .)kernel.org \
--cc=kuleshovmail@gmail$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox