public inbox for git@vger.kernel.org 
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox•com>
To: "Torsten Bögershausen" <tboegi@web•de>
Cc: Michael Blume <blume.mike@gmail•com>,
	Git List <git@vger•kernel.org>, David Aguilar <davvid@gmail•com>
Subject: Re: Deprecation warnings under XCode
Date: Mon, 01 Dec 2014 10:04:57 -0800	[thread overview]
Message-ID: <xmqqoarnp7p2.fsf@gitster.dls.corp.google.com> (raw)
In-Reply-To: <547BFD42.3040104@web.de> ("Torsten Bögershausen"'s message of "Mon, 01 Dec 2014 06:31:46 +0100")

Torsten Bögershausen <tboegi@web•de> writes:

> On 12/01/2014 04:02 AM, Michael Blume wrote:
>> I have no idea whether this should concern anyone, but my mac build of git shows
>>
>>      CC imap-send.o
>> imap-send.c:183:36: warning: 'ERR_error_string' is deprecated: first
>> deprecated in OS X 10.7 [-Wdeprecated-declarations]
>>          fprintf(stderr, "%s: %s\n", func,
>> ERR_error_string(ERR_get_error(), NULL));
>>                                            ^
> []
> Isn't the warning a warning ;-)
> I don't see this warnings because my openssl comes from
> /opt/local/include (Mac ports)
> Does anybody know which new functions exist in Mac OS X versions >= 10.7  ?

I am not a Mac person, but is this about APPLE_COMMON_CRYPTO support
added in 4dcd7732 (Makefile: add support for Apple CommonCrypto
facility, 2013-05-19) and be4c828b (imap-send: eliminate HMAC
deprecation warnings on Mac OS X, 2013-05-19)?  Specifically, the
log message for 4dcd7732 begins like so:

    Makefile: add support for Apple CommonCrypto facility
    
    As of Mac OS X 10.7, Apple deprecated all OpenSSL functions due to
    OpenSSL ABI instability, thus leading to build warnings.  As a
    replacement, Apple encourages developers to migrate to its own (stable)
    CommonCrypto facility.

In the Makefile we seem to have this:

    # Define NO_APPLE_COMMON_CRYPTO if you are building on Darwin/Mac OS X
    # and do not want to use Apple's CommonCrypto library.  This allows you
    # to provide your own OpenSSL library, for example from MacPorts.

which makes it sound like using APPLE_COMMON_CRYPTO is the default
for Mac.  Perhaps those who do want to use CommonCrypto to avoid
warnings should not define that macro?

  parent reply	other threads:[~2014-12-01 18:05 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-12-01  3:02 Deprecation warnings under XCode Michael Blume
2014-12-01  5:31 ` Torsten Bögershausen
2014-12-01 17:51   ` OpenSSL deprecation warnings under Xcode Kyle J. McKay
2014-12-01 18:04   ` Junio C Hamano [this message]
2014-12-03  0:37     ` Deprecation warnings under XCode Eric Sunshine
2014-12-03  1:12       ` Michael Blume
2014-12-03  3:09         ` Eric Sunshine
2014-12-03 10:04           ` David Aguilar
2014-12-03 12:54             ` Torsten Bögershausen
2014-12-04  3:44               ` David Aguilar
2014-12-03 18:16             ` Eric Sunshine

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqqoarnp7p2.fsf@gitster.dls.corp.google.com \
    --to=gitster@pobox$(echo .)com \
    --cc=blume.mike@gmail$(echo .)com \
    --cc=davvid@gmail$(echo .)com \
    --cc=git@vger$(echo .)kernel.org \
    --cc=tboegi@web$(echo .)de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox