From: Junio C Hamano <gitster@pobox•com>
To: "René Scharfe" <l.s.r@web•de>
Cc: Git Mailing List <git@vger•kernel.org>
Subject: Re: [PATCH] imap-send: simplify v_issue_imap_cmd() and get_cmd_result() using starts_with()
Date: Tue, 02 Sep 2014 12:23:08 -0700 [thread overview]
Message-ID: <xmqqoauxzv1f.fsf@gitster.dls.corp.google.com> (raw)
In-Reply-To: <5401F860.4030902@web.de> ("René Scharfe"'s message of "Sat, 30 Aug 2014 18:14:24 +0200")
René Scharfe <l.s.r@web•de> writes:
> Use starts_with() instead of memcmp() to check if NUL-terminated
> strings match prefixes. This gets rid of some magic string length
> constants.
>
> Signed-off-by: Rene Scharfe <l.s.r@web•de>
> ---
> imap-send.c | 9 ++++++---
> 1 file changed, 6 insertions(+), 3 deletions(-)
>
> diff --git a/imap-send.c b/imap-send.c
> index 524fbab..b079a0d 100644
> --- a/imap-send.c
> +++ b/imap-send.c
> @@ -802,7 +802,10 @@ static int get_cmd_result(struct imap_store *ctx, struct imap_cmd *tcmd)
> resp = DRV_OK;
> else {
> if (!strcmp("NO", arg)) {
> - if (cmdp->cb.create && cmd && (cmdp->cb.trycreate || !memcmp(cmd, "[TRYCREATE]", 11))) { /* SELECT, APPEND or UID COPY */
> + if (cmdp->cb.create && cmd &&
> + (cmdp->cb.trycreate ||
> + starts_with(cmd, "[TRYCREATE]"))) {
> + /* SELECT, APPEND or UID COPY */
> p = strchr(cmdp->cmd, '"');
> if (!issue_imap_cmd(ctx, NULL, "CREATE \"%.*s\"", (int)(strchr(p + 1, '"') - p + 1), p)) {
> resp = RESP_BAD;
Do we want this hunk, given that it will disappear with the
tf/imap-send-create topic at e0d8e308 (imap-send: create target
mailbox if it is missing, 2014-08-01)?
next prev parent reply other threads:[~2014-09-02 19:23 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-30 16:14 [PATCH] imap-send: simplify v_issue_imap_cmd() and get_cmd_result() using starts_with() René Scharfe
2014-09-02 19:23 ` Junio C Hamano [this message]
2014-09-03 3:50 ` René Scharfe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqoauxzv1f.fsf@gitster.dls.corp.google.com \
--to=gitster@pobox$(echo .)com \
--cc=git@vger$(echo .)kernel.org \
--cc=l.s.r@web$(echo .)de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox