public inbox for git@vger.kernel.org 
 help / color / mirror / Atom feed

From: Junio C Hamano <gitster@pobox•com>
To: "Torsten Bögershausen" <tboegi@web•de>
Cc: git@vger•kernel.org
Subject: Re: [PATCH] t5551: fix the 50,000 tag test
Date: Mon, 09 Jun 2014 22:53:31 -0700	[thread overview]
Message-ID: <xmqqoay1b99g.fsf@gitster.dls.corp.google.com> (raw)
In-Reply-To: <53967F48.1080103@web.de> ("Torsten Bögershausen"'s message of "Tue, 10 Jun 2014 05:45:12 +0200")

Torsten Bögershausen <tboegi@web•de> writes:

> Thanks for digging, as we now know better:
> do you want to squeeze in someting like this:
>
> s/Since the day/Since commit 5e2c7cd2/ 

I usually do not dig only to give suggestions to others, which will
risk the time I spent to go to total waste.  When I find the log
message lacking, and if the patch looked otherwise OK enough, I do
the digging myself in order to tweak to reduce one round-trip
(otherwise I'd just discard and tell the submitter to do the
digging).  I may send out what I learned as a response, but that is
a mere "side effect"; the primary effect of queuing an improved
patch has often already happened when you see the result of my
digging.

I do not recall what I did for this particular patch, but you should
be able to fetch and run "git log origin/master..origin/pu" to find
out what I did ;-).

Thanks.

     prev parent reply	other threads:[~2014-06-10  5:53 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-06-05 21:36 [PATCH] t5551: fix the 50,000 tag test Torsten Bögershausen
2014-06-09 19:16 ` Junio C Hamano
2014-06-10  3:45   ` Torsten Bögershausen
2014-06-10  5:53     ` Junio C Hamano [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqqoay1b99g.fsf@gitster.dls.corp.google.com \
    --to=gitster@pobox$(echo .)com \
    --cc=git@vger$(echo .)kernel.org \
    --cc=tboegi@web$(echo .)de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox